chore: Improve handling of HTMLImageElement in texture uploads #11343
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Updated gpuUploadImageResource to convert HTMLImageElement to canvas for WebGPU compatibility. - Removed redundant image conversion logic from ImageSource constructor. - Added visual tests for rendering HTMLImageElement as a texture. - Included new snapshot images for WebGL1, WebGL2, and WebGPU.
There was a problem hiding this comment.
Pull Request Overview
This PR improves HTMLImageElement handling during WebGPU texture uploads by moving the canvas conversion step from the TextureSource to the GPU uploader.
- Conversion of HTMLImageElement to canvas is now performed in the WebGPU upload step.
- Removed legacy conversion logic from the ImageSource class.
- Updated test files to reflect the change in conversion handling.
Reviewed Changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/rendering/renderers/gpu/texture/uploaders/gpuUploadImageSource.ts | Added conversion of HTMLImageElement to a canvas during the WebGPU upload process and implemented a corresponding warning. |
| src/rendering/renderers/tests/Extract.test.ts | Removed an outdated test that validated conversion and warning behavior for HTMLImageElement in ImageSource. |
| tests/visual/scenes/textures/image-source-texture.scene.ts | Added a visual test to validate rendering of textures created from HTMLImageElement. |
| src/rendering/renderers/shared/texture/sources/ImageSource.ts | Removed canvas conversion logic for HTMLImageElement to align with the new processing path. |
Comments suppressed due to low confidence (1)
src/rendering/renderers/gpu/texture/uploaders/gpuUploadImageSource.ts:20
- The new conversion logic for HTMLImageElement in the GPU uploader is not covered by any tests. Consider adding tests to verify both the canvas conversion and the proper replacement of the resource.
if (globalThis.HTMLImageElement && resource instanceof HTMLImageElement)
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
bigtimebuddy
approved these changes
Apr 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
HTMLImages are no longer converted to a canvas onthe texture side. This now happens on the WebGPU Image upload step, as WebGL can handle Images as resources just fine!
Should help #11331 a bit with Texture.from
Pre-Merge Checklist
npm run lint)npm run test)