-
-
Notifications
You must be signed in to change notification settings - Fork 4.9k
feat: DOMContainer #11340
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: DOMContainer #11340
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Your PR title doesn't match the required format. The title should be in this format:
chore: update Text docs
fix: text not rendering
feat: add new feature to Text
breaking: remove Text#resolution
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 4ef48c1:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great just nit feedback.
Co-authored-by: Matt Karl <matt@mattkarl.com>
Description of change
DOM Container Support
This PR adds support for integrating DOM elements within the PixiJS scene graph, allowing HTML elements to be positioned and transformed alongside other PixiJS objects.
Features
DOMContainer
class for wrapping HTML elementsDOMPipe
for managing DOM elements in the scenePerformance Considerations
Example Usage
Notes
Open questions
DOMContainer
the best name?@Zyie , will this PR cause issues with offscreen canvas or other things that don't have access to the dom?should this be imported - or included by default?Pre-Merge Checklist
npm run lint
)npm run test
)