Skip to content

Conversation

F-star
Copy link
Contributor

@F-star F-star commented Jan 26, 2025

fixes issue #11055

migrate to v8, according to PR #10125

Description of change
Pre-Merge Checklist
  • Tests and/or benchmarks are included
  • Documentation is changed or added
  • Lint process passed (npm run lint)
  • Tests passed (npm run test)

Copy link

codesandbox-ci bot commented Jan 26, 2025

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit d842ba1:

Sandbox Source
pixi.js-sandbox Configuration

@F-star F-star changed the title Add: Spritesheet option cachePrefix feat: spritesheet option cachePrefix Jan 26, 2025
@bigtimebuddy
Copy link
Member

Thank you! Were there any tests from v7 that we can also port to test this?

@F-star
Copy link
Contributor Author

F-star commented Jan 26, 2025

Thank you! Were there any tests from v7 that we can also port to test this?

Yes, I will migrate the tests later, but some APIs are a bit different, so I need to try to understand them first.

@bigtimebuddy
Copy link
Member

No problem. If you need any context on Asset changes, I'm sure @Zyie or I can answer.

@Zyie Zyie added the ✅ Ready To Merge Helpful when issues are in the queue waiting to get merged. This means the PR is completed and has t label May 4, 2025
@Zyie Zyie added this pull request to the merge queue May 4, 2025
Merged via the queue into pixijs:dev with commit 42fedd5 May 4, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✅ Ready To Merge Helpful when issues are in the queue waiting to get merged. This means the PR is completed and has t
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants