-
-
Notifications
You must be signed in to change notification settings - Fork 4.9k
feat: update Earcut to v3.0.0 #11214
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
da02de1
to
932d591
Compare
What are the big difference between v2 and v3 of earcut? |
There aren't many. Here's the differences copy and pasted from the release notes:
Granted there's also the entirety of 2.1.5 to 2.2.4 that don't have any release notes at all. The one actual change to the API was switching from CommonJS to ESM which changed the exports slightly and made I was really thinking this'd be a tiny bump in the dependencies, the fact that Jest was so annoying to grapple with was an unexpected development. I just hope it won't be a blocker to getting this merged, if it is I really would like to work with you in any way to work through this. It might seem odd to care about such a small change but the global |
87cda43
to
fa4cfb6
Compare
@Zyie would you mind taking a look at if this PR can be merged? Hopefully not being impatient, just want to make sure it hasn't slipped under your radar. |
They do, they were just kept in a different place (I moved them from being kept in the readme to using GitHub releases): https://github.com/mapbox/earcut/tree/v2.2.4#changelog |
Hey @LukeAbby, Thanks for this! I’m planning to merge it in for the next minor release. While it looks safe, there’s a small chance it could impact users, so I’d prefer to include it in 8.10.0 rather than a patch. A minor version bump signals a bit more strongly that there’s a change they might want to be aware of. |
Okay, sounds great! Sorry if that was the plan all along and I was just being impatient haha. |
@mourner Good to know! And thanks for the library. |
I want to update earcut to v3.0.0 because I have a project that makes their own
earcut
global that conflicts with the 2.0.0 era globalearcut
variable with TypeScript typings.Wrangling with Jest unfortunately took most of the time because apparently its support for node module dependencies written in ESM is lacking. If anyone knows of a better way I'm all ears!