Skip to content

fix: Restore gl extensions state on context restore #11299

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 20, 2025

Conversation

ddenisyuk
Copy link
Contributor

Description of change

After restoring the context, you usually need to reactivate or reinitialize any WebGL extensions manually because they are not automatically restored.

This is related to #11247 and possibly another issues concerning context restoration.

Pre-Merge Checklist
  • Tests and/or benchmarks are included
  • Documentation is changed or added
  • Lint process passed (npm run lint)
  • Tests passed (npm run test)

@ddenisyuk ddenisyuk changed the title Restore gl extensions state on context restore fix: Restore gl extensions state on context restore Feb 21, 2025
Copy link

codesandbox-ci bot commented Feb 21, 2025

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 7c0ede7:

Sandbox Source
pixi.js-sandbox Configuration

vforsh pushed a commit to vforsh/pixi-8-astc-black-screen that referenced this pull request Feb 25, 2025
@schmooky
Copy link

schmooky commented Mar 2, 2025

That would help a lot, we face the same issues on extensions

@Zyie Zyie added the ✅ Ready To Merge Helpful when issues are in the queue waiting to get merged. This means the PR is completed and has t label Mar 13, 2025
@Zyie Zyie added this pull request to the merge queue Mar 20, 2025
Merged via the queue into pixijs:dev with commit bd0e692 Mar 20, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✅ Ready To Merge Helpful when issues are in the queue waiting to get merged. This means the PR is completed and has t
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants