feat: The build (ShapeBuilder) method should report its success #11283
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 4624e6a:
|
|
ooh, yes - i like the idea here! |
|
would you be able to add some tests around this please? |
|
Added tests, finalized the code and fixed the problem with GpuContext.isBatchable when the 'batch' mode is set |
GoodBoyDigital
approved these changes
May 9, 2025
bigtimebuddy
reviewed
May 9, 2025
src/scene/graphics/shared/__tests__/GraphicsContextSystem.test.ts
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ShapeBuilder includes 2 methods: build, triangulate. Using the buildRectangle example, we see that there is a check !(width >= 0 && height >= 0). In this case, the points are not added, and then triangulate (which adds undefined) is performed and BatchableGraphics is created for the discarded primitive. I suggest an option in which build decides what to do with the primitive, and if it is incorrect, false will be returned. In this case, we will not add BatchableGraphics and run this primitive in pipe.