Add global move events #9067
Merged
Add global move events #9067
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Tianlan Zhou <bobby825@126.com>
SuperSodaSea
approved these changes
Jan 17, 2023
This was referenced Jan 20, 2023
|
This is crazy slow on spine animations guys! You should revert this ASAP or make a default setting to disable it. Animations with many meshes have to be constantly walked through hundreds of times when the mouse moves on something. There is absolutely no point of doing this. I don't have a single pointer or touche event in my application and I had to debug this a whole day to figure out why my animations are running 20 FPS when the mouse is moving... |
|
@newtoncodes Thanks for reporting. Can you create a new issue so we can track this? You on the latest 7.2.0 prerelease I assume? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR add 3 new events
globalpointermove,globaltouchmove, andglobalmousemoveThese move events behave like the old interaction system, and is the equivalent of setting
events.rootBoundary.moveOnAllThis PR also fixes an issue with
displayObject.addEventListenertypes not being correctly assigned in theglobal.d.tsfile