Better detection of scissor rect #7896
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ivanpopelyshev - Everything looks good in our codebase, thanks again! |
bigtimebuddy
approved these changes
Oct 23, 2021
|
Thanks again for everyone's time and effort here! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
V6 fix for #7855 , attempt 3
Scissor area calculation is re-done, part of code is taken from Filters. I found several small bugs before this thing actually passed tests.
Bugged: https://www.pixiplayground.com/#/edit/2qJVNoyRHDVPMtaTJ4hCY
Fixed: https://www.pixiplayground.com/#/edit/zvssY9ET_SfF3DHbANP9j
@jmlee2k test with nested masks: https://www.pixiplayground.com/#/edit/xlV1rc892j75GaGmBbuQQ
Can be tested on iOS15 or any integrated videocard with ANGLE