Skip to content

Add SKIP policy to not expect a PROXY header #96

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 13, 2023
Merged

Add SKIP policy to not expect a PROXY header #96

merged 1 commit into from
Mar 13, 2023

Conversation

kayrus
Copy link
Contributor

@kayrus kayrus commented Mar 1, 2023

Resolves #95

@kayrus kayrus force-pushed the skip-header branch 2 times, most recently from e891fdd to 2211fd7 Compare March 1, 2023 20:25
@kayrus kayrus changed the title Add SKIP policy to not expect PROXY header Add SKIP policy to not expect a PROXY header Mar 1, 2023
@kayrus
Copy link
Contributor Author

kayrus commented Mar 3, 2023

@pires could you please take a look on this PR?

@pires
Copy link
Owner

pires commented Mar 5, 2023

Please, add tests and documentation. I think what you wrote in #95 description is a good starting point.

@coveralls
Copy link

coveralls commented Mar 5, 2023 •
edited
Loading

Coverage Status

Coverage: 95.444% (-0.2%) from 95.603% when pulling e9fdbf2 on kayrus:skip-header into 2fac219 on pires:main.

@kayrus
Copy link
Contributor Author

kayrus commented Mar 5, 2023

@pires where should I put the documentation?

@kayrus kayrus force-pushed the skip-header branch 5 times, most recently from d8f0cc6 to 6a007c7 Compare March 6, 2023 11:55
@kayrus
Copy link
Contributor Author

kayrus commented Mar 7, 2023

@pires is there anything else I need to add to the PR?

@pires pires self-requested a review March 8, 2023 22:00
@pires
Copy link
Owner

pires commented Mar 8, 2023

I need a couple days to review this. Thank you very much for your contribution.

pires
pires requested changes Mar 13, 2023
View reviewed changes
Copy link
Owner

@pires pires left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry @kayrus but with a recent bump in the Go tooling version(s), tests that spawn go-routines fail to pass go vet if they have calls to Fatalf and such. Can you, please, work on that?

Other than that, this LGTM!

@kayrus
Copy link
Contributor Author

kayrus commented Mar 13, 2023

@pires fixed

pires
pires approved these changes Mar 13, 2023
View reviewed changes
Copy link
Owner

@pires pires left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for your contribution.

@pires pires merged commit 4f677b5 into pires:main Mar 13, 2023
@kayrus kayrus deleted the skip-header branch March 13, 2023 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pires pires pires approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CIDR based policy for a simple non-PROXY traffic
3 participants
@kayrus @pires @coveralls