Bump DefaultReadHeaderTimeout to 10s #84
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When dealing with slow networks and TLS, 200ms is often hit. Bump the default timeout to 10s, which is what crupto/tls uses for the TLS handshake. Closes: pires#83
94700b3 to
7f1f93d
Compare
pires
reviewed
Sep 15, 2021
| @@ -12,7 +12,7 @@ import ( | |||
| // be read from the wire, if Listener.ReaderHeaderTimeout is not set. | |||
| // It's kept as a global variable so to make it easier to find and override, | |||
| // e.g. go build -ldflags -X "github.com/pires/go-proxyproto.DefaultReadHeaderTimeout=1s" | |||
| var DefaultReadHeaderTimeout = 200 * time.Millisecond | |||
| var DefaultReadHeaderTimeout = 10 * time.Second | |||
There was a problem hiding this comment.
Can you please add the reason here why this timeout? Or maybe just point to whatever const/var you mentioned is exposed by stdlib.
There was a problem hiding this comment.
There's no other reason than "it's a reasonable timeout".
pires
reviewed
Sep 15, 2021
| @@ -265,6 +265,8 @@ func TestReadHeaderTimeoutIsReset(t *testing.T) { | |||
| // we expect the actual address and port to be returned, | |||
| // rather than the ProxyHeader we defined. | |||
| func TestReadHeaderTimeoutIsEmpty(t *testing.T) { | |||
| DefaultReadHeaderTimeout = 200 * time.Millisecond | |||
There was a problem hiding this comment.
I think this may have impact on subsequent tests, so maybe override the listener timeout instead.
There was a problem hiding this comment.
The point of the test is to check the default.
|
Gentle ping |
|
Sorry @emersion in between work and sickness, I just haven't been able to look into this. Thanks a lot for your contribution, once more! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When dealing with slow networks and TLS, 200ms is often hit. Bump
the default timeout to 10s, which is what crupto/tls uses for the
TLS handshake.
Closes: #83