Skip to content

Support v1 UNKNOWN and v2 UNSPEC when command is LOCAL #61

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jan 18, 2021
Merged

Support v1 UNKNOWN and v2 UNSPEC when command is LOCAL #61

merged 4 commits into from
Jan 18, 2021

Conversation

pires
Copy link
Owner

@pires pires commented Jan 17, 2021 •
edited
Loading

Fixes #60

I took the opportunity to improve test debuggability for v1 and v2 code.

Warning: changes to v1 errror handling may break someone's code but should be trivial to address. I'm taking this breaking change lightly because of that and because this is still a 0.x release, which should clearly communicate the API is not stable.

pires added 2 commits January 16, 2021 19:14
@pires
v1: support UNKNOWN
de485d5 
Also improved testing debugability by having each table test carry a
description.

Refs #60

Signed-off-by: Pires <pjpires@gmail.com>
@pires
v2: support UNSPEC inet family
bb6fb2b 
But only when command is LOCAL.

Refs #60

Signed-off-by: Pires <pjpires@gmail.com>
@pires pires added this to the 0.4 milestone Jan 17, 2021
@coveralls
Copy link

coveralls commented Jan 17, 2021 •
edited
Loading

Coverage Status

Coverage increased (+0.6%) to 94.094% when pulling 4b450a5 on feature/proxy_unknown into adbbabe on master.

@pires
Copy link
Owner Author

pires commented Jan 17, 2021

@emersion maybe you want to take a look?

pires added 2 commits January 17, 2021 10:52
@pires
v1: fix misleading typo
4239e12 
Signed-off-by: Pires <pjpires@gmail.com>
@pires
v1: validate UNSPEC to show how it's used to signal UNKNOWN
4b450a5 
Signed-off-by: Pires <pjpires@gmail.com>
@pires pires force-pushed the feature/proxy_unknown branch from 7f8aafb to 4b450a5 Compare January 17, 2021 10:55
@pires pires merged commit 22bc614 into master Jan 18, 2021
@pires pires deleted the feature/proxy_unknown branch January 18, 2021 10:25
@bohanyang
Copy link

Sorry, seems that I found a bug... the server behind PP listener got the 15th and 16th 00 00 bytes, which is the length (for LOCAL UNSPEC it's zero)

bohanyang
bohanyang reviewed Jan 19, 2021
View reviewed changes
@bohanyang bohanyang mentioned this pull request Jan 19, 2021
Merged
@bohanyang bohanyang mentioned this pull request Jan 27, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@bohanyang bohanyang bohanyang left review comments

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
0.4
Development

Successfully merging this pull request may close these issues.

Parsing v2 UNSPEC and v1 PROXY UNKNOWN not implemented
3 participants
@pires @coveralls @bohanyang