Skip to content

Allow IPv6 compat addresses when parsing TCPv6 in V1 header #49

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Allow IPv6 compat addresses when parsing TCPv6 in V1 header #49

wants to merge 1 commit into from

Conversation

emersion
Copy link
Contributor

Addresses like 0:0:0:0:0:ffff:7f00:1 should be allowed when parsing
IPv6 protocols.

Not sure how to make this work, so submitting as a draft so that we're at least aware of the issue...

@emersion
wip: allow IPv6 compat addresses when parsing TCPv6
dd016a4 
Addresses like 0:0:0:0:0:ffff:7f00:1 should be allowed when parsing
IPv6 protocols.
@emersion emersion changed the title Allow IPv6 compat addresses when parsing TCPv6 Allow IPv6 compat addresses when parsing TCPv6 in V1 header Oct 28, 2020
@pires pires mentioned this pull request Oct 28, 2020
Closed
@pires
Copy link
Owner

pires commented Oct 28, 2020

Wait, didn't #49 fix this?

@pires
Copy link
Owner

pires commented Oct 28, 2020

Ah, this is about IP4to6 where an IPv4 address can be encoded in IPv6, as the example you show up above. I think this is a good-to-have and not blocking 0.3.0 on it.

@emersion
Copy link
Contributor Author

Yes, I agree

Base automatically changed from master to main January 18, 2021 10:29
@isedev
Copy link

isedev commented Mar 2, 2021 •
edited
Loading

How about logic along these lines?

func parseV1IPAddress(v6 bool, addr string) (ip net.IP, err error) {
	ip := net.ParseIP(addr)
	tryV4 := ip.To4()
	hasDot := (strings.Index(addr, ".") != -1)
	hasColon := (strings.Index(addr, ":") != -1)
	if (!v6 && (tryV4 == nil || hasColon)) || (v6 && hasDot) {
		err = errors.New("no good")
	}
	return
}

Which give these results:

addr                 error with v6=false?     error with v6=true?
8912:adfb::0124      yes                      no
10.10.0.10           no                       yes
::ffff:0a0a:0a0a     yes                      no
::ffff:10.10.10.10   yes                      yes

The ParseIP() and To4() outputs:

addr                 ParseIP                                       To4
8912:adfb::0124      len=16  ip=8912adfb000000000000000000000124   len=0  ip=
10.10.0.10           len=16  ip=00000000000000000000ffff0a0a000a   len=4  ip=0a0a000a
::ffff:0a0a:0a0a     len=16  ip=00000000000000000000ffff0a0a0a0a   len=4  ip=0a0a0a0a
::ffff:10.10.10.10   len=16  ip=00000000000000000000ffff0a0a0a0a   len=4  ip=0a0a0a0a

The ::ffff:10.10.10.10 is legal IPv6 text but not supported by the proxy protocol standard, as I read it.

If you agree, I can work up a PR.

@isedev
Copy link

isedev commented Mar 2, 2021

On similar note, HeaderProxyFromAddrs will silently assume TCP4 if given a IP4to6 address as source.
Not convinced that's proper behaviour. Can't see how to change that though without also changing function signature...

@Freeaqingme Freeaqingme mentioned this pull request Apr 29, 2022
Closed
@pires pires mentioned this pull request Mar 6, 2023
Merged
@pires pires closed this in #97 Mar 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@emersion @pires @isedev