-
-
Notifications
You must be signed in to change notification settings - Fork 117
Closed
Description
$ golint ./...
addr_proto.go:7:2: exported const UNSPEC should have comment (or a comment on this block) or be unexported
header.go:15:2: comment on exported var SIGV1 should be of the form "SIGV1 ..."
header.go:17:2: exported var SIGV2 should have comment or be unexported
header.go:96:1: exported method Header.TCPAddrs should have comment or be unexported
header.go:105:1: exported method Header.UDPAddrs should have comment or be unexported
header.go:114:1: exported method Header.UnixAddrs should have comment or be unexported
header.go:123:1: exported method Header.IPs should have comment or be unexported
header.go:133:1: exported method Header.Ports should have comment or be unexported
header_test.go:16:2: don't use ALL_CAPS in Go names; use CamelCase
header_test.go:17:2: don't use ALL_CAPS in Go names; use CamelCase
header_test.go:18:2: don't use ALL_CAPS in Go names; use CamelCase
header_test.go:20:2: don't use ALL_CAPS in Go names; use CamelCase
tlv.go:14:2: comment on exported const PP2_TYPE_ALPN should be of the form "PP2_TYPE_ALPN ..."
tlv.go:15:2: don't use ALL_CAPS in Go names; use CamelCase
tlv.go:16:2: don't use ALL_CAPS in Go names; use CamelCase
tlv.go:16:2: exported const PP2_TYPE_AUTHORITY should have comment (or a comment on this block) or be unexported
tlv.go:17:2: don't use ALL_CAPS in Go names; use CamelCase
tlv.go:18:2: don't use ALL_CAPS in Go names; use CamelCase
tlv.go:19:2: don't use ALL_CAPS in Go names; use CamelCase
tlv.go:20:2: don't use ALL_CAPS in Go names; use CamelCase
tlv.go:21:2: don't use ALL_CAPS in Go names; use CamelCase
tlv.go:22:2: don't use ALL_CAPS in Go names; use CamelCase
tlv.go:23:2: don't use ALL_CAPS in Go names; use CamelCase
tlv.go:24:2: don't use ALL_CAPS in Go names; use CamelCase
tlv.go:25:2: don't use ALL_CAPS in Go names; use CamelCase
tlv.go:27:2: comment on exported const PP2_TYPE_MIN_CUSTOM should be of the form "PP2_TYPE_MIN_CUSTOM ..."
tlv.go:28:2: don't use ALL_CAPS in Go names; use CamelCase
tlv.go:29:2: don't use ALL_CAPS in Go names; use CamelCase
tlv.go:30:2: don't use ALL_CAPS in Go names; use CamelCase
tlv.go:31:2: don't use ALL_CAPS in Go names; use CamelCase
tlv.go:32:2: don't use ALL_CAPS in Go names; use CamelCase
tlv.go:33:2: don't use ALL_CAPS in Go names; use CamelCase
tlv.go:37:2: exported var ErrTruncatedTLV should have comment or be unexported
version_cmd.go:7:2: exported const LOCAL should have comment (or a comment on this block) or be unexported
tlvparse/aws.go:13:2: comment on exported const PP2_TYPE_AWS should be of the form "PP2_TYPE_AWS ..."
tlvparse/aws.go:14:2: don't use ALL_CAPS in Go names; use CamelCase
tlvparse/aws.go:15:2: don't use ALL_CAPS in Go names; use CamelCase
tlvparse/aws.go:15:2: exported const PP2_SUBTYPE_AWS_VPCE_ID should have comment (or a comment on this block) or be unexported
tlvparse/aws.go:20:1: exported function IsAWSVPCEndpointID should have comment or be unexported
tlvparse/aws.go:24:1: exported function AWSVPCEndpointID should have comment or be unexported
tlvparse/azure.go:13:2: comment on exported const PP2_TYPE_AZURE should be of the form "PP2_TYPE_AZURE ..."
tlvparse/azure.go:14:2: don't use ALL_CAPS in Go names; use CamelCase
tlvparse/azure.go:15:2: don't use ALL_CAPS in Go names; use CamelCase
tlvparse/azure.go:15:2: exported const PP2_SUBTYPE_AZURE_PRIVATEENDPOINT_LINKID should have comment (or a comment on this block) or be unexported
tlvparse/ssl.go:12:2: comment on exported const PP2_BITFIELD_CLIENT_SSL should be of the form "PP2_BITFIELD_CLIENT_SSL ..."
tlvparse/ssl.go:13:2: don't use ALL_CAPS in Go names; use CamelCase
tlvparse/ssl.go:14:2: don't use ALL_CAPS in Go names; use CamelCase
tlvparse/ssl.go:14:2: exported const PP2_BITFIELD_CLIENT_CERT_CONN should have comment (or a comment on this block) or be unexported
tlvparse/ssl.go:15:2: don't use ALL_CAPS in Go names; use CamelCase
tlvparse/ssl.go:20:1: comment on exported type PP2SSL should be of the form "PP2SSL ..." (with optional leading article)
tlvparse/ssl.go:97:1: comment on exported function IsSSL should be of the form "IsSSL ..."
tlvparse/ssl.go:149:1: comment on exported function FindSSL should be of the form "FindSSL ..."
😭
Don't forget to set --set_exit_status
so CI fails builds if lint is violated.