Skip to content

Remove dead code / unused references #370

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 13, 2021
Merged

Remove dead code / unused references #370

merged 2 commits into from
Jan 13, 2021

Conversation

czgu
Copy link
Collaborator

@czgu czgu commented Jan 7, 2021 •
edited
Loading

Removed unused exports via

ts-prune -i stories | grep -v "used in module"

which removes storybook and exports used internally

There are a few components that were removed, one worth mentioning is that SingleCRUD is now GenericCRUD and the old GenericCRUD is removed.

The remaining exports are

datahub/webapp/const/chartColors.ts:76 - accentColor
datahub/webapp/hooks/useForceUpdate.ts:3 - useForceUpdate
datahub/webapp/lib/dataHubUI.ts:11 - sendAlert
datahub/webapp/redux/dataDoc/action.ts:492 - getDataDocEditors
datahub/webapp/redux/queryView/action.ts:151 - updateOrderBy
datahub/webapp/redux/search/action.ts:83 - resetSearch
datahub/webapp/redux/search/types.ts:12 - DisplayOption

which I skipped waiting to see if they would be used in the future.

also turned on

        "noUnusedLocals": true,
        "noUnusedParameters": true,

to remove any unused imports

@czgu czgu requested a review from meowcodes January 7, 2021 20:48
@meowcodes meowcodes merged commit 616fb6d into master Jan 13, 2021
@meowcodes meowcodes deleted the removegraph branch January 13, 2021 19:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@meowcodes meowcodes meowcodes approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@czgu @meowcodes