Skip to content

Make Markdown use external links, Make adhoc query persists in indexDB #362

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 18, 2020
Merged

Make Markdown use external links, Make adhoc query persists in indexDB #362

merged 2 commits into from
Dec 18, 2020

Conversation

czgu
Copy link
Collaborator

@czgu czgu commented Dec 18, 2020 •
edited
Loading

  • When markdown is rendered, use component with open in a new tab as true.
  • Fixed newTab behavior for external links
  • ensure ad-hoc query content is persisted via local storage
  • make "clear" for ad-hoc query also remove the execution (but not the query engine selection)

@czgu czgu added the enhancement New feature or request label Dec 18, 2020
@czgu czgu requested a review from meowcodes December 18, 2020 22:45
@meowcodes meowcodes merged commit 12e2297 into master Dec 18, 2020
@meowcodes meowcodes deleted the adhocqueryfix branch December 18, 2020 22:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@meowcodes meowcodes meowcodes approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@czgu @meowcodes