Skip to content

Adding search and replace to datadocs #30

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 1, 2020
Merged

Adding search and replace to datadocs #30

merged 2 commits into from
May 1, 2020

Conversation

czgu
Copy link
Collaborator

@czgu czgu commented Apr 29, 2020 •
edited
Loading

vscode like UI, launched via cmd+f
image

as you can see the features include:

  • match case search
  • regex search
  • replace 1
  • replace all
  • jump to next
  • jump to previous

Search highlight in text cell (occasionally broken, need to find the root cause)
image
image

You can also match by regex
image

meowcodes
meowcodes approved these changes Apr 30, 2020
View reviewed changes
datahub/webapp/components/DataDoc/DataDocSearchAndReplace.tsx Outdated
}
}, []);

// Throttling because if you press enter too focus it
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

to*

@czgu czgu merged commit 75ecdd7 into master May 1, 2020
@czgu czgu deleted the searchreplace branch May 1, 2020 20:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@meowcodes meowcodes meowcodes approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@czgu @meowcodes