Skip to content

Add Gradle toolchain setup. #1294

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Dec 1, 2021
Merged

Add Gradle toolchain setup. #1294

merged 3 commits into from
Dec 1, 2021

Conversation

Tapchicoma
Copy link
Collaborator

@Tapchicoma Tapchicoma commented Nov 30, 2021 •
edited
Loading

Description

  • Unify Kotlin setup via compiler plugin and use jvm toolchain with configured language version 8.
  • Add tasks to run additionally tests on JDK 11 - "testOnJdk11"
  • Change CI setup to not use java versions matrix - JDK 11 will be auto-provisioned by Gradle itself
  • Update Dokka to 1.6.0 version (previous version caused issues on CI run)

Checklist

  • tests are added
  • CHANGELOG.md is updated

@Tapchicoma
Add JVM toolchain setup.
c34efe5 
Configure project to use JDK 1.8 toolchain to compile itself and run the tests.
@Tapchicoma
Add separate task to run tests on JDK 11.
cbad6bc 
This task utilizes toolchain feature. CI was updated to run only on agents with JDK 1.8 preinstalled. JDK 11 will be installed by Gradle.
@Tapchicoma Tapchicoma requested a review from shashachu November 30, 2021 12:07
shashachu
shashachu reviewed Nov 30, 2021
View reviewed changes
@Tapchicoma Tapchicoma mentioned this pull request Dec 1, 2021
Closed
@shashachu shashachu merged commit 1e7cf75 into pinterest:master Dec 1, 2021
@paul-dingemans paul-dingemans mentioned this pull request Mar 18, 2022
Merged
5 tasks
@Goooler Goooler mentioned this pull request Jan 29, 2023
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shashachu shashachu shashachu approved these changes

+2 more reviewers

@mateuszkwiecinski mateuszkwiecinski mateuszkwiecinski left review comments

@romtsn romtsn romtsn approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Tapchicoma @shashachu @romtsn @mateuszkwiecinski