statistics: fix the test case by increase the time interval #51139
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: hi-rustin <rustin.liu@gmail.com>
winoros
approved these changes
Feb 19, 2024
hawkingrei
approved these changes
Feb 19, 2024
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hawkingrei, winoros The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #51139 +/- ##
================================================
+ Coverage 70.5910% 72.7153% +2.1242%
================================================
Files 1467 1467
Lines 434739 434794 +55
================================================
+ Hits 306887 316162 +9275
+ Misses 108594 98739 -9855
- Partials 19258 19893 +635
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: close #51142
Problem Summary:
What changed and how does it work?
We received some unstable test reports regarding certain cases. The instability arose from the fact that the case attempted to verify if the job had failed just by now. However, in some instances, if the test case was running slowly, it wouldn't be considered as just failing now because it is more than one second. To address this, we decided to omit the fail reason check in this PR. Additionally, we changed the timer intervals from 1 second to 10 seconds.
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.