Skip to content

Conversation

hawkingrei
Copy link
Member

@hawkingrei hawkingrei commented Jan 30, 2024

What problem does this PR solve?

Issue Number: close #50799

Problem Summary:

What changed and how does it work?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jan 30, 2024
Copy link

ti-chi-bot bot commented Jan 30, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Defined2014, wshwsh12

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [Defined2014,wshwsh12]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jan 30, 2024
Copy link

ti-chi-bot bot commented Jan 30, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-01-30 06:25:50.962529587 +0000 UTC m=+1460392.526827290: ☑️ agreed by wshwsh12.
  • 2024-01-30 06:28:01.563630657 +0000 UTC m=+1460523.127928361: ☑️ agreed by Defined2014.

Copy link

codecov bot commented Jan 30, 2024

Codecov Report

Merging #50812 (1df4ec2) into master (b5542c5) will increase coverage by 2.1204%.
Report is 4 commits behind head on master.
The diff coverage is n/a.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #50812        +/-   ##
================================================
+ Coverage   70.5411%   72.6615%   +2.1204%     
================================================
  Files          1465       1465                
  Lines        433462     433543        +81     
================================================
+ Hits         305769     315019      +9250     
+ Misses       108485      98663      -9822     
- Partials      19208      19861       +653     
Flag Coverage Δ
integration 49.0806% <ø> (?)
unit 70.3221% <ø> (-0.0398%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 54.2940% <ø> (ø)
parser ∅ <ø> (∅)
br 51.2170% <ø> (+5.4558%) ⬆️

@ti-chi-bot ti-chi-bot bot merged commit 62e6bb3 into pingcap:master Jan 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

flaky test TestInterruptedDuringSpilling
3 participants