Skip to content

exeuctor: fix data race for test TestInterruptedDuringSort #50681

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 24, 2024
Merged

exeuctor: fix data race for test TestInterruptedDuringSort #50681

merged 1 commit into from
Jan 24, 2024

Conversation

wshwsh12
Copy link
Contributor

What problem does this PR solve?

Issue Number: close #50679

Problem Summary:

What changed and how does it work?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/needs-triage-completed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 24, 2024
@tiprow tiprow
Copy link

tiprow bot commented Jan 24, 2024

Hi @wshwsh12. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@wshwsh12
Copy link
Contributor Author

/check-issue-triage-complete

@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jan 24, 2024
@hawkingrei hawkingrei requested a review from XuHuaiyu January 24, 2024 03:50
@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Jan 24, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hawkingrei, XuHuaiyu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [XuHuaiyu,hawkingrei]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jan 24, 2024
@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Jan 24, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-01-24 03:46:45.401407447 +0000 UTC m=+932446.965705153: ☑️ agreed by hawkingrei.
  • 2024-01-24 03:51:56.788937027 +0000 UTC m=+932758.353234722: ☑️ agreed by XuHuaiyu.

@codecov Codecov
Copy link

codecov bot commented Jan 24, 2024 •
edited
Loading

Codecov Report

Merging #50681 (8139971) into master (8e5d98d) will decrease coverage by 14.6574%.
Report is 2 commits behind head on master.
The diff coverage is n/a.

Additional details and impacted files 
@@                Coverage Diff                @@
##             master     #50681         +/-   ##
=================================================
- Coverage   70.3551%   55.6977%   -14.6574%     
=================================================
  Files          1456       1567        +111     
  Lines        420737     588505     +167768     
=================================================
+ Hits         296010     327784      +31774     
- Misses       104400     237952     +133552     
- Partials      20327      22769       +2442
Flag Coverage Δ
integration 36.8535% <ø> (?)
unit 70.3229% <ø> (-0.0205%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 54.0269% <ø> (ø)
parser ∅ <ø> (∅)
br 56.6591% <ø> (+6.1282%) ⬆️

@ti-chi-bot ti-chi-bot bot merged commit 8aff603 into pingcap:master Jan 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hawkingrei hawkingrei hawkingrei approved these changes

@XuHuaiyu XuHuaiyu XuHuaiyu approved these changes

Assignees
No one assigned
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

DATA RACE in the TestInterruptedDuringSort
3 participants
@wshwsh12 @hawkingrei @XuHuaiyu