Skip to content

DATA RACE in the TestManagerHandleTasks #50297

@hawkingrei

Description

@hawkingrei

Bug Report

Please answer these questions before submitting your issue. Thanks!

1. Minimal reproduce step (Required)

2. What did you expect to see? (Required)

3. What did you see instead (Required)

==================
WARNING: DATA RACE
Write at 0x00c000fa26a0 by goroutine 63:
  github.com/pingcap/tidb/pkg/disttask/framework/taskexecutor.TestManagerHandleTasks.func3()
      pkg/disttask/framework/taskexecutor/manager_test.go:310 +0x46
  runtime.call32()
      src/runtime/asm_amd64.s:748 +0x42
  reflect.Value.Call()
      GOROOT/src/reflect/value.go:380 +0xb5
  go.uber.org/mock/gomock.(*Call).DoAndReturn.func1()
      external/org_uber_go_mock/gomock/call.go:138 +0x944
  go.uber.org/mock/gomock.(*Controller).Call()
      external/org_uber_go_mock/gomock/controller.go:229 +0x11c
  github.com/pingcap/tidb/pkg/disttask/framework/mock.(*MockTaskExecutor).Run()
      pkg/disttask/framework/mock/task_executor_mock.go:394 +0x189
  github.com/pingcap/tidb/pkg/disttask/framework/taskexecutor.(*Manager).handleExecutableTask()
      pkg/disttask/framework/taskexecutor/manager.go:402 +0x10a3
  github.com/pingcap/tidb/pkg/disttask/framework/taskexecutor.(*Manager).handleExecutableTasks.func1()
      pkg/disttask/framework/taskexecutor/manager.go:257 +0xfb
  github.com/pingcap/tidb/pkg/disttask/framework/taskexecutor.TestManagerHandleTasks.getPoolRunFn.func7.1()
      pkg/disttask/framework/taskexecutor/manager_test.go:38 +0x81
Previous read at 0x00c000fa26a0 by goroutine 67:
  github.com/pingcap/tidb/pkg/disttask/framework/taskexecutor.TestManagerHandleTasks.func4()
      pkg/disttask/framework/taskexecutor/manager_test.go:315 +0x33
  github.com/stretchr/testify/assert.Eventually.func1()
      external/com_github_stretchr_testify/assert/assertions.go:1852 +0x33
Goroutine 63 (running) created at:
  github.com/pingcap/tidb/pkg/disttask/framework/taskexecutor.TestManagerHandleTasks.getPoolRunFn.func7()
      pkg/disttask/framework/taskexecutor/manager_test.go:36 +0xe4
  runtime.call16()
      src/runtime/asm_amd64.s:747 +0x42
  reflect.Value.Call()
      GOROOT/src/reflect/value.go:380 +0xb5
  go.uber.org/mock/gomock.(*Call).DoAndReturn.func1()
      external/org_uber_go_mock/gomock/call.go:138 +0x944
  go.uber.org/mock/gomock.(*Controller).Call()
      external/org_uber_go_mock/gomock/controller.go:229 +0x11c
  github.com/pingcap/tidb/pkg/disttask/framework/mock.(*MockPool).Run()
      pkg/disttask/framework/mock/task_executor_mock.go:289 +0xe6
  github.com/pingcap/tidb/pkg/disttask/framework/taskexecutor.(*Manager).handleExecutableTasks()
      pkg/disttask/framework/taskexecutor/manager.go:255 +0x605
  github.com/pingcap/tidb/pkg/disttask/framework/taskexecutor.(*Manager).handleTasks()
      pkg/disttask/framework/taskexecutor/manager.go:223 +0x64e
  github.com/pingcap/tidb/pkg/disttask/framework/taskexecutor.TestManagerHandleTasks()
      pkg/disttask/framework/taskexecutor/manager_test.go:313 +0x1b67
  testing.tRunner()
      GOROOT/src/testing/testing.go:1595 +0x261
  testing.(*T).Run.func1()
      GOROOT/src/testing/testing.go:1648 +0x44
Goroutine 67 (finished) created at:
  github.com/stretchr/testify/assert.Eventually()
      external/com_github_stretchr_testify/assert/assertions.go:1852 +0x3b5
  github.com/stretchr/testify/require.Eventually()
      external/com_github_stretchr_testify/require/require.go:401 +0xb5
  github.com/pingcap/tidb/pkg/disttask/framework/taskexecutor.TestManagerHandleTasks()
      pkg/disttask/framework/taskexecutor/manager_test.go:314 +0x1c5c
  testing.tRunner()
      GOROOT/src/testing/testing.go:1595 +0x261
  testing.(*T).Run.func1()
      GOROOT/src/testing/testing.go:1648 +0x44
================== 

4. What is your TiDB version? (Required)

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions