Skip to content

DATA RACE TestMultiValuedIndexOnlineDDL #42372

@hawkingrei

Description

@hawkingrei

Bug Report

Please answer these questions before submitting your issue. Thanks!

1. Minimal reproduce step (Required)

2. What did you expect to see? (Required)

3. What did you see instead (Required)

=================
WARNING: DATA RACE
Read at 0x00c0186691f0 by goroutine 519066:
  github.com/pingcap/tidb/planner/core.newBasePlan()
      planner/core/plan.go:728 +0x8a
  github.com/pingcap/tidb/planner/core.newBaseLogicalPlan()
      planner/core/plan.go:743 +0x10f
  github.com/pingcap/tidb/planner/core.LogicalTableDual.Init()
      planner/core/initialize.go:175 +0x23f
  github.com/pingcap/tidb/planner/core.rewriteAstExpr()
      planner/core/expression_rewriter.go:74 +0x274
  github.com/pingcap/tidb/expression.ColumnInfos2ColumnsAndNames()
      expression/expression.go:1001 +0xd7a
  github.com/pingcap/tidb/util/admin.makeRowDecoder()
      util/admin/admin.go:196 +0x3b6
  github.com/pingcap/tidb/util/admin.iterRecords()
      util/admin/admin.go:224 +0x6b5
  github.com/pingcap/tidb/util/admin.CheckRecordAndIndex()
      util/admin/admin.go:186 +0x4fd
  github.com/pingcap/tidb/executor.(*CheckTableExec).checkTableRecord()
      executor/executor.go:1097 +0x644
  github.com/pingcap/tidb/executor.(*CheckTableExec).Next.func2.1()
      executor/executor.go:1053 +0x24d
  github.com/pingcap/tidb/util.WithRecovery()
      util/misc.go:96 +0x6d
  github.com/pingcap/tidb/executor.(*CheckTableExec).Next.func2()
      executor/executor.go:1042 +0xc7
  github.com/pingcap/tidb/util.(*WaitGroupWrapper).Run.func1()
      util/wait_group_wrapper.go:154 +0x73
Previous write at 0x00c0186691f0 by goroutine 519065:
  github.com/pingcap/tidb/planner/core.newBasePlan()
      planner/core/plan.go:728 +0xa5
  github.com/pingcap/tidb/planner/core.newBaseLogicalPlan()
      planner/core/plan.go:743 +0x10f
  github.com/pingcap/tidb/planner/core.LogicalTableDual.Init()
      planner/core/initialize.go:175 +0x23f
  github.com/pingcap/tidb/planner/core.rewriteAstExpr()
      planner/core/expression_rewriter.go:74 +0x274
  github.com/pingcap/tidb/expression.ColumnInfos2ColumnsAndNames()
      expression/expression.go:1001 +0xd7a
  github.com/pingcap/tidb/util/admin.makeRowDecoder()
      util/admin/admin.go:196 +0x3b6
  github.com/pingcap/tidb/util/admin.iterRecords()
      util/admin/admin.go:224 +0x6b5
  github.com/pingcap/tidb/util/admin.CheckRecordAndIndex()
      util/admin/admin.go:186 +0x4fd
  github.com/pingcap/tidb/executor.(*CheckTableExec).checkTableRecord()
      executor/executor.go:1097 +0x644
  github.com/pingcap/tidb/executor.(*CheckTableExec).Next.func2.1()
      executor/executor.go:1053 +0x24d
  github.com/pingcap/tidb/util.WithRecovery()
      util/misc.go:96 +0x6d
  github.com/pingcap/tidb/executor.(*CheckTableExec).Next.func2()
      executor/executor.go:1042 +0xc7
  github.com/pingcap/tidb/util.(*WaitGroupWrapper).Run.func1()
      util/wait_group_wrapper.go:154 +0x73
Goroutine 519066 (running) created at:
  github.com/pingcap/tidb/util.(*WaitGroupWrapper).Run()
      util/wait_group_wrapper.go:152 +0xe4
  github.com/pingcap/tidb/executor.(*CheckTableExec).Next()
      executor/executor.go:1041 +0xa0f
  github.com/pingcap/tidb/executor.Next()
      executor/executor.go:326 +0x326
  github.com/pingcap/tidb/executor.(*ExecStmt).next()
      executor/adapter.go:1212 +0x89
  github.com/pingcap/tidb/executor.(*ExecStmt).handleNoDelayExecutor()
      executor/adapter.go:957 +0x4f9
  github.com/pingcap/tidb/executor.(*ExecStmt).handleNoDelay()
      executor/adapter.go:782 +0x34a
  github.com/pingcap/tidb/executor.(*ExecStmt).Exec()
      executor/adapter.go:577 +0x129e
  github.com/pingcap/tidb/session.runStmt()
      session/session.go:2333 +0x62f
  github.com/pingcap/tidb/session.(*session).ExecuteStmt()
      session/session.go:2190 +0x10dd
  github.com/pingcap/tidb/testkit.(*TestKit).ExecWithContext()
      testkit/testkit.go:325 +0x8ae
  github.com/pingcap/tidb/testkit.(*TestKit).MustExecWithContext()
      testkit/testkit.go:133 +0xb7
  github.com/pingcap/tidb/testkit.(*TestKit).MustExec()
      testkit/testkit.go:128 +0x138
  github.com/pingcap/tidb/ddl_test.TestMultiValuedIndexOnlineDDL()
      ddl/mv_index_test.go:60 +0x550
  github.com/pingcap/tidb/domain.(*Domain).rebuildSysVarCache()
      domain/sysvar_cache.go:146 +0x8c4
  github.com/pingcap/tidb/domain.(*Domain).LoadSysVarCacheLoop()
      domain/domain.go:1470 +0xa8
  github.com/pingcap/tidb/session.BootstrapSession()
      session/session.go:3314 +0x6d3
  github.com/pingcap/tidb/domain.(*Domain).GetSessionCache()
      domain/sysvar_cache.go:62 +0x5c
  github.com/pingcap/tidb/session.(*session).loadCommonGlobalVariablesIfNeeded()
      session/session.go:3656 +0x104
  github.com/pingcap/tidb/session.(*session).ExecuteStmt()
      session/session.go:2093 +0x145
  github.com/pingcap/tidb/session.(*session).ExecuteInternal()
      session/session.go:1628 +0x31b
  github.com/pingcap/tidb/domain.(*Domain).LoadPrivilegeLoop()
      domain/domain.go:1414 +0x130
  github.com/pingcap/tidb/session.BootstrapSession()
      session/session.go:3307 +0x684
  github.com/pingcap/tidb/testkit.bootstrap()
      testkit/mockstore.go:85 +0xac
  github.com/pingcap/tidb/testkit.CreateMockStoreAndDomain()
      testkit/mockstore.go:70 +0xe9
  github.com/pingcap/tidb/ddl_test.TestMultiValuedIndexOnlineDDL()
      ddl/mv_index_test.go:29 +0x58
  testing.tRunner()
      GOROOT/src/testing/testing.go:1576 +0x216
  testing.(*T).Run.func1()
      GOROOT/src/testing/testing.go:1629 +0x47
Goroutine 519065 (running) created at:
  github.com/pingcap/tidb/util.(*WaitGroupWrapper).Run()
      util/wait_group_wrapper.go:152 +0xe4
  github.com/pingcap/tidb/executor.(*CheckTableExec).Next()
      executor/executor.go:1041 +0xa0f
  github.com/pingcap/tidb/executor.Next()
      executor/executor.go:326 +0x326
  github.com/pingcap/tidb/executor.(*ExecStmt).next()
      executor/adapter.go:1212 +0x89
  github.com/pingcap/tidb/executor.(*ExecStmt).handleNoDelayExecutor()
      executor/adapter.go:957 +0x4f9
  github.com/pingcap/tidb/executor.(*ExecStmt).handleNoDelay()
      executor/adapter.go:782 +0x34a
  github.com/pingcap/tidb/executor.(*ExecStmt).Exec()
      executor/adapter.go:577 +0x129e
  github.com/pingcap/tidb/session.runStmt()
      session/session.go:2333 +0x62f
  github.com/pingcap/tidb/session.(*session).ExecuteStmt()
      session/session.go:2190 +0x10dd
  github.com/pingcap/tidb/testkit.(*TestKit).ExecWithContext()
      testkit/testkit.go:325 +0x8ae
  github.com/pingcap/tidb/testkit.(*TestKit).MustExecWithContext()
      testkit/testkit.go:133 +0xb7
  github.com/pingcap/tidb/testkit.(*TestKit).MustExec()
      testkit/testkit.go:128 +0x138
  github.com/pingcap/tidb/ddl_test.TestMultiValuedIndexOnlineDDL()
      ddl/mv_index_test.go:60 +0x550
  github.com/pingcap/tidb/domain.(*Domain).rebuildSysVarCache()
      domain/sysvar_cache.go:146 +0x8c4
  github.com/pingcap/tidb/domain.(*Domain).LoadSysVarCacheLoop()
      domain/domain.go:1470 +0xa8
  github.com/pingcap/tidb/session.BootstrapSession()
      session/session.go:3314 +0x6d3
  github.com/pingcap/tidb/domain.(*Domain).GetSessionCache()
      domain/sysvar_cache.go:62 +0x5c
  github.com/pingcap/tidb/session.(*session).loadCommonGlobalVariablesIfNeeded()
      session/session.go:3656 +0x104
  github.com/pingcap/tidb/session.(*session).ExecuteStmt()
      session/session.go:2093 +0x145
  github.com/pingcap/tidb/session.(*session).ExecuteInternal()
      session/session.go:1628 +0x31b
  github.com/pingcap/tidb/domain.(*Domain).LoadPrivilegeLoop()
      domain/domain.go:1414 +0x130
  github.com/pingcap/tidb/session.BootstrapSession()
      session/session.go:3307 +0x684
  github.com/pingcap/tidb/testkit.bootstrap()
      testkit/mockstore.go:85 +0xac
  github.com/pingcap/tidb/testkit.CreateMockStoreAndDomain()
      testkit/mockstore.go:70 +0xe9
  github.com/pingcap/tidb/ddl_test.TestMultiValuedIndexOnlineDDL()
      ddl/mv_index_test.go:29 +0x58
  testing.tRunner()
      GOROOT/src/testing/testing.go:1576 +0x216
  testing.(*T).Run.func1()
      GOROOT/src/testing/testing.go:1629 +0x47
================== 

4. What is your TiDB version? (Required)

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions