Skip to content

DATA RACE in the TestResourceGroupBasic #42119

New issue
New issue
Closed
#42148
Closed
DATA RACE in the TestResourceGroupBasic#42119
#42148
Assignees
CabinfeverB
Labels
component/testseverity/moderatetype/bugThe issue is confirmed as a bug.
@hawkingrei

Description

@hawkingrei
hawkingrei
opened on Mar 12, 2023

Bug Report

Please answer these questions before submitting your issue. Thanks!

1. Minimal reproduce step (Required)

2. What did you expect to see? (Required)

3. What did you see instead (Required)

==================
WARNING: DATA RACE
Read at 0x00c005ceab68 by goroutine 48:
  ddl/resourcegrouptest/resourcegrouptest_test_test.TestResourceGroupBasic.func3()
      ddl/resourcegrouptest/resource_group_test.go:108 +0x105
  ddl/resourcegrouptest/resourcegrouptest_test_test.TestResourceGroupBasic()
      ddl/resourcegrouptest/resource_group_test.go:113 +0x9ad
  github.com/pingcap/tidb/session.runStmt()
      session/session.go:2333 +0x62f
  github.com/pingcap/tidb/session.(*session).ExecuteStmt()
      session/session.go:2190 +0x10dd
  github.com/pingcap/tidb/testkit.(*TestKit).ExecWithContext()
      testkit/testkit.go:323 +0x8ae
  github.com/pingcap/tidb/testkit.(*TestKit).MustExecWithContext()
      testkit/testkit.go:132 +0xb7
  github.com/pingcap/tidb/testkit.(*TestKit).MustExec()
      testkit/testkit.go:127 +0xf7
  ddl/resourcegrouptest/resourcegrouptest_test_test.TestResourceGroupBasic()
      ddl/resourcegrouptest/resource_group_test.go:84 +0x5d8
  github.com/pingcap/tidb/session.runStmt()
      session/session.go:2333 +0x62f
  github.com/pingcap/tidb/session.(*session).ExecuteStmt()
      session/session.go:2190 +0x10dd
  github.com/pingcap/tidb/testkit.(*TestKit).ExecWithContext()
      testkit/testkit.go:323 +0x8ae
  github.com/pingcap/tidb/testkit.(*TestKit).MustExecWithContext()
      testkit/testkit.go:132 +0xb7
  github.com/pingcap/tidb/testkit.(*TestKit).MustExec()
      testkit/testkit.go:127 +0xf7
  ddl/resourcegrouptest/resourcegrouptest_test_test.TestResourceGroupBasic()
      ddl/resourcegrouptest/resource_group_test.go:80 +0x57c
  github.com/pingcap/tidb/session.runStmt()
      session/session.go:2333 +0x62f
  github.com/pingcap/tidb/session.(*session).ExecuteStmt()
      session/session.go:2190 +0x10dd
  github.com/pingcap/tidb/testkit.(*TestKit).ExecWithContext()
      testkit/testkit.go:323 +0x8ae
  github.com/pingcap/tidb/testkit.(*TestKit).MustExecWithContext()
      testkit/testkit.go:132 +0xb7
  github.com/pingcap/tidb/testkit.(*TestKit).MustExec()
      testkit/testkit.go:127 +0xf7
  ddl/resourcegrouptest/resourcegrouptest_test_test.TestResourceGroupBasic()
      ddl/resourcegrouptest/resource_group_test.go:58 +0x384
  github.com/pingcap/tidb/session.runStmt()
      session/session.go:2333 +0x62f
  github.com/pingcap/tidb/session.(*session).ExecuteStmt()
      session/session.go:2190 +0x10dd
  github.com/pingcap/tidb/testkit.(*TestKit).ExecWithContext()
      testkit/testkit.go:323 +0x8ae
  github.com/pingcap/tidb/testkit.(*TestKit).MustExecWithContext()
      testkit/testkit.go:132 +0xb7
  github.com/pingcap/tidb/testkit.(*TestKit).MustExec()
      testkit/testkit.go:127 +0xf7
  ddl/resourcegrouptest/resourcegrouptest_test_test.TestResourceGroupBasic()
      ddl/resourcegrouptest/resource_group_test.go:52 +0x2e4
  github.com/pingcap/tidb/domain.(*Domain).rebuildSysVarCache()
      domain/sysvar_cache.go:146 +0x8c4
  github.com/pingcap/tidb/domain.(*Domain).LoadSysVarCacheLoop()
      domain/domain.go:1470 +0xa8
  github.com/pingcap/tidb/session.BootstrapSession()
      session/session.go:3314 +0x6d3
  github.com/pingcap/tidb/domain.(*Domain).GetSessionCache()
      domain/sysvar_cache.go:62 +0x5c
  github.com/pingcap/tidb/session.(*session).loadCommonGlobalVariablesIfNeeded()
      session/session.go:3656 +0x104
  github.com/pingcap/tidb/session.(*session).ExecuteStmt()
      session/session.go:2093 +0x145
  github.com/pingcap/tidb/session.(*session).ExecuteInternal()
      session/session.go:1628 +0x31b
  github.com/pingcap/tidb/domain.(*Domain).LoadPrivilegeLoop()
      domain/domain.go:1414 +0x130
  github.com/pingcap/tidb/session.BootstrapSession()
      session/session.go:3307 +0x684
  github.com/pingcap/tidb/testkit.bootstrap()
      testkit/mockstore.go:85 +0xac
  github.com/pingcap/tidb/testkit.CreateMockStoreAndDomain()
      testkit/mockstore.go:70 +0xe9
  ddl/resourcegrouptest/resourcegrouptest_test_test.TestResourceGroupBasic()
      ddl/resourcegrouptest/resource_group_test.go:35 +0x58
  testing.tRunner()
      GOROOT/src/testing/testing.go:1576 +0x216
  testing.(*T).Run.func1()
      GOROOT/src/testing/testing.go:1629 +0x47
Previous write at 0x00c005ceab68 by goroutine 28556:
  ddl/resourcegrouptest/resourcegrouptest_test_test.TestResourceGroupBasic.func1()
      ddl/resourcegrouptest/resource_group_test.go:45 +0x135
  github.com/pingcap/tidb/ddl/internal/callback.(*TestDDLCallback).OnJobUpdated()
      ddl/internal/callback/callback.go:122 +0x210
  github.com/pingcap/tidb/ddl.(*ddl).delivery2worker.func1()
      ddl/job_table.go:314 +0x1161
  github.com/pingcap/tidb/util.(*WaitGroupWrapper).Run.func1()
      util/wait_group_wrapper.go:154 +0x73
Goroutine 48 (running) created at:
  testing.(*T).Run()
      GOROOT/src/testing/testing.go:1629 +0x805
  testing.runTests.func1()
      GOROOT/src/testing/testing.go:2036 +0x8d
  testing.tRunner()
      GOROOT/src/testing/testing.go:1576 +0x216
  testing.runTests()
      GOROOT/src/testing/testing.go:2034 +0x87c
  testing.(*M).Run()
      GOROOT/src/testing/testing.go:1906 +0xb44
  main.main()
      bazel-out/k8-fastbuild/bin/ddl/resourcegrouptest/resourcegrouptest_test_/testmain.go:104 +0x5d0
Goroutine 28556 (finished) created at:
  github.com/pingcap/tidb/util.(*WaitGroupWrapper).Run()
      util/wait_group_wrapper.go:152 +0xe4
  github.com/pingcap/tidb/ddl.(*ddl).delivery2worker()
      ddl/job_table.go:244 +0x1b7
  github.com/pingcap/tidb/ddl.(*ddl).loadDDLJobAndRun()
      ddl/job_table.go:237 +0x57c
  github.com/pingcap/tidb/ddl.(*ddl).startDispatchLoop()
      ddl/job_table.go:209 +0xadc
  github.com/pingcap/tidb/ddl.(*ddl).startDispatchLoop-fm()
      <autogenerated>:1 +0x39
  github.com/pingcap/tidb/util.(*WaitGroupWrapper).Run.func1()
      util/wait_group_wrapper.go:154 +0x73
================== 
==================
WARNING: DATA RACE
Read at 0x00c005ceab68 by goroutine 48:
  ddl/resourcegrouptest/resourcegrouptest_test_test.TestResourceGroupBasic.func2()
      ddl/resourcegrouptest/resource_group_test.go:64 +0x105
  ddl/resourcegrouptest/resourcegrouptest_test_test.TestResourceGroupBasic()
      ddl/resourcegrouptest/resource_group_test.go:69 +0x45a
  github.com/pingcap/tidb/session.runStmt()
      session/session.go:2333 +0x62f
  github.com/pingcap/tidb/session.(*session).ExecuteStmt()
      session/session.go:2190 +0x10dd
  github.com/pingcap/tidb/testkit.(*TestKit).ExecWithContext()
      testkit/testkit.go:323 +0x8ae
  github.com/pingcap/tidb/testkit.(*TestKit).MustExecWithContext()
      testkit/testkit.go:132 +0xb7
  github.com/pingcap/tidb/testkit.(*TestKit).MustExec()
      testkit/testkit.go:127 +0xf7
  ddl/resourcegrouptest/resourcegrouptest_test_test.TestResourceGroupBasic()
      ddl/resourcegrouptest/resource_group_test.go:58 +0x384
  github.com/pingcap/tidb/session.runStmt()
      session/session.go:2333 +0x62f
  github.com/pingcap/tidb/session.(*session).ExecuteStmt()
      session/session.go:2190 +0x10dd
  github.com/pingcap/tidb/testkit.(*TestKit).ExecWithContext()
      testkit/testkit.go:323 +0x8ae
  github.com/pingcap/tidb/testkit.(*TestKit).MustExecWithContext()
      testkit/testkit.go:132 +0xb7
  github.com/pingcap/tidb/testkit.(*TestKit).MustExec()
      testkit/testkit.go:127 +0xf7
  ddl/resourcegrouptest/resourcegrouptest_test_test.TestResourceGroupBasic()
      ddl/resourcegrouptest/resource_group_test.go:52 +0x2e4
  github.com/pingcap/tidb/domain.(*Domain).rebuildSysVarCache()
      domain/sysvar_cache.go:146 +0x8c4
  github.com/pingcap/tidb/domain.(*Domain).LoadSysVarCacheLoop()
      domain/domain.go:1470 +0xa8
  github.com/pingcap/tidb/session.BootstrapSession()
      session/session.go:3314 +0x6d3
  github.com/pingcap/tidb/domain.(*Domain).GetSessionCache()
      domain/sysvar_cache.go:62 +0x5c
  github.com/pingcap/tidb/session.(*session).loadCommonGlobalVariablesIfNeeded()
      session/session.go:3656 +0x104
  github.com/pingcap/tidb/session.(*session).ExecuteStmt()
      session/session.go:2093 +0x145
  github.com/pingcap/tidb/session.(*session).ExecuteInternal()
      session/session.go:1628 +0x31b
  github.com/pingcap/tidb/domain.(*Domain).LoadPrivilegeLoop()
      domain/domain.go:1414 +0x130
  github.com/pingcap/tidb/session.BootstrapSession()
      session/session.go:3307 +0x684
  github.com/pingcap/tidb/testkit.bootstrap()
      testkit/mockstore.go:85 +0xac
  github.com/pingcap/tidb/testkit.CreateMockStoreAndDomain()
      testkit/mockstore.go:70 +0xe9
  ddl/resourcegrouptest/resourcegrouptest_test_test.TestResourceGroupBasic()
      ddl/resourcegrouptest/resource_group_test.go:35 +0x58
  testing.tRunner()
      GOROOT/src/testing/testing.go:1576 +0x216
  testing.(*T).Run.func1()
      GOROOT/src/testing/testing.go:1629 +0x47
Previous write at 0x00c005ceab68 by goroutine 26773:
  ddl/resourcegrouptest/resourcegrouptest_test_test.TestResourceGroupBasic.func1()
      ddl/resourcegrouptest/resource_group_test.go:45 +0x135
  github.com/pingcap/tidb/ddl/internal/callback.(*TestDDLCallback).OnJobUpdated()
      ddl/internal/callback/callback.go:122 +0x210
  github.com/pingcap/tidb/ddl.(*ddl).delivery2worker.func1()
      ddl/job_table.go:314 +0x1161
  github.com/pingcap/tidb/util.(*WaitGroupWrapper).Run.func1()
      util/wait_group_wrapper.go:154 +0x73
Goroutine 48 (running) created at:
  testing.(*T).Run()
      GOROOT/src/testing/testing.go:1629 +0x805
  testing.runTests.func1()
      GOROOT/src/testing/testing.go:2036 +0x8d
  testing.tRunner()
      GOROOT/src/testing/testing.go:1576 +0x216
  testing.runTests()
      GOROOT/src/testing/testing.go:2034 +0x87c
  testing.(*M).Run()
      GOROOT/src/testing/testing.go:1906 +0xb44
  main.main()
      bazel-out/k8-fastbuild/bin/ddl/resourcegrouptest/resourcegrouptest_test_/testmain.go:104 +0x5d0
Goroutine 26773 (finished) created at:
  github.com/pingcap/tidb/util.(*WaitGroupWrapper).Run()
      util/wait_group_wrapper.go:152 +0xe4
  github.com/pingcap/tidb/ddl.(*ddl).delivery2worker()
      ddl/job_table.go:244 +0x1b7
  github.com/pingcap/tidb/ddl.(*ddl).loadDDLJobAndRun()
      ddl/job_table.go:237 +0x57c
  github.com/pingcap/tidb/ddl.(*ddl).startDispatchLoop()
      ddl/job_table.go:209 +0xadc
  github.com/pingcap/tidb/ddl.(*ddl).startDispatchLoop-fm()
      <autogenerated>:1 +0x39
  github.com/pingcap/tidb/util.(*WaitGroupWrapper).Run.func1()
      util/wait_group_wrapper.go:154 +0x73
==================

4. What is your TiDB version? (Required)

Metadata

Metadata

Assignees

Labels

component/testseverity/moderatetype/bugThe issue is confirmed as a bug.

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions