use hdr histogram & make maxLatency configurable in tpcc workload #65
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM |
mahjonp
reviewed
Nov 20, 2020
tpcc/workload.go
Outdated
| @@ -329,7 +335,10 @@ func (w *Workloader) OutputStats(ifSummaryReport bool) { | |||
| hist, e := w.rtMeasurement.OpSumMeasurement["new_order"] | |||
| if e && !hist.Empty() { | |||
| result := hist.GetInfo() | |||
| fmt.Printf("tpmC: %.1f\n", result.Ops*60) | |||
| const SpecWarehouseFactor = 12.86 | |||
There was a problem hiding this comment.
Suggested change
| const SpecWarehouseFactor = 12.86 | |
| const specWarehouseFactor = 12.86 |
mahjonp
reviewed
Nov 20, 2020
pkg/measurement/measure.go
Outdated
| @@ -7,10 +7,13 @@ import ( | |||
| "time" | |||
| ) | |||
|
|
|||
| const DefaultMaxLatency = 16 * time.Second | |||
There was a problem hiding this comment.
16s is too small for TPC-H and CH-benCHmark, they usually take one minute to ten minutes, and more sf means a longer duration
There was a problem hiding this comment.
Seems an unreasonable report on TPC-H:
[Summary] Q1: 10.33s
[Summary] Q10: 15.84s
[Summary] Q11: 14.23s
[Summary] Q12: 15.19s
[Summary] Q13: 10.44s
[Summary] Q14: 14.87s
[Summary] Q15: 15.57s
[Summary] Q16: 12.62s
[Summary] Q17: 14.50s
[Summary] Q18: 14.90s
[Summary] Q19: 10.33s
[Summary] Q2: 11.51s
[Summary] Q20: 12.48s
[Summary] Q21: 15.84s
[Summary] Q22: 10.80s
[Summary] Q3: 15.84s
[Summary] Q4: 15.84s
[Summary] Q6: 7.11s
[Summary] Q7: 15.84s
[Summary] Q8: 15.84s
[Summary] Q9: 14.76s
Signed-off-by: lysu <sulifx@gmail.com>
|
@mahjonp hi, it has be signed please help merge if free, thx~ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
now, we are analyze tpcc workload latency and found current output bucket count is too small and default latency configuration(16s) is too high for our situtation
so this PR try to: