Skip to content

Add empty card #1670

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Mar 24, 2025
Merged

Add empty card #1670

merged 4 commits into from
Mar 24, 2025

Conversation

wendevlin
Copy link
Contributor

Description

New mushroom-empty-card

Related Issue

This PR fixes or closes issue: fixes #

Motivation and Context

How Has This Been Tested

Types of changes

  • 🐛 Bug fix (non-breaking change which fixes an issue)
  • 🚀 New feature (non-breaking change which adds functionality)
  • 🌎 Translation (addition or update a translation)
  • ⚙️ Tech (code style improvement, performance improvement or dependencies bump)
  • 📚 Documentation (fix or addition in the documentation)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have tested the change locally.
  • I followed the steps if I add a new language .

@piitaya piitaya self-requested a review March 12, 2025 08:39
@piitaya piitaya self-assigned this Mar 12, 2025
@piitaya piitaya added the enhancement New feature or request label Mar 12, 2025
piitaya
piitaya reviewed Mar 13, 2025
View reviewed changes
Copy link
Owner

@piitaya piitaya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the contribution @wendevlin 🙂

@wendevlin wendevlin requested a review from piitaya March 13, 2025 13:48
@piitaya
Copy link
Owner

piitaya commented Mar 24, 2025

Thank you @wendevlin

@piitaya piitaya merged commit 2192128 into piitaya:main Mar 24, 2025
1 check passed
@crhbetz
Copy link

crhbetz commented Apr 1, 2025

Genius move to include this into an update to release on the 1st of April :-)

@mikeschmick
Copy link

Next up - blank Chip?! Please!

@piitaya
Copy link
Owner

piitaya commented Apr 1, 2025

Next up - blank Chip?! Please!

There is a spacer chip already, right?

@deadrubberboy
Copy link

Next up - blank Chip?! Please!

There is a spacer chip already, right?

Not that I’m aware of? At least not one that takes the same exact amount of space as a regular icon only chip.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@piitaya piitaya piitaya approved these changes

Assignees

@piitaya piitaya

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@wendevlin @piitaya @crhbetz @mikeschmick @deadrubberboy