Skip to content

Conversation

savino
Copy link
Contributor

@savino savino commented Feb 15, 2025

Description

Add the fan direction button as optional control.

Related Issue

This PR fixes or closes issue: #1149

Motivation and Context

This card is very useful to control also a ceiling fan, the problem is that the current implementation does not provide the possibility to change the direction of the fan by the card itself; seems that also during the winter, the change of direction is one of the most used feature because of the comfort/efficency balancing that depends on the room occupancy. Currently to perform the action it is necessary to drill down in the detail card that is not so comfortable.

How Has This Been Tested

I tested the addition first with the local demo server, then I've loaded a js build directly into my "production" home assistant instance.
I tested it with a Cecotec 5400 that is supported via tuya integration.

Types of changes

  • 🐛 Bug fix (non-breaking change which fixes an issue)
  • 🚀 New feature (non-breaking change which adds functionality)
  • 🌎 Translation (addition or update a translation)
  • ⚙️ Tech (code style improvement, performance improvement or dependencies bump)
  • 📚 Documentation (fix or addition in the documentation)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have tested the change locally.
  • I followed the steps if I add a new language .

Copy link
Owner

@piitaya piitaya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you !
Can you remove the translations that are not english and your native language. I prefer to have translations done by native speaker.

I also made a suggestion to remove the active state for reverse mode.

@piitaya piitaya changed the title Implementation of feature request #1149 Add fan direction button to fan card Feb 28, 2025
@piitaya piitaya added the enhancement New feature or request label Feb 28, 2025
Copy link
Owner

@piitaya piitaya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you 👍

@piitaya piitaya merged commit 7f4cc54 into piitaya:main Mar 11, 2025
@savino
Copy link
Contributor Author

savino commented Mar 11, 2025

Hi Paul, sorry for the delay, but I had also a strange problem testing it again on the latest version (2025.3.x) of home assistant, maybe a js caching issue or something similar, but it required time to see the changes on my "production" environment. Thanks to you.

@piitaya
Copy link
Owner

piitaya commented Mar 11, 2025

No problem, thank you for the update !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants