Change QUIC endpoint creation to use abstract socket for improved runtime handling #119
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR updates the QUIC endpoint creation to utilize an abstract socket in order to improve runtime management and error handling. The key changes include switching from quinn::Endpoint::new to quinn::Endpoint::new_with_abstract_socket and wrapping the UDP socket with the runtime.
Comments suppressed due to low confidence (1)
taxy/src/server/quic.rs:184
- Ensure that tests are added to cover the behavior of the new abstract socket functionality, especially under scenarios where socket wrapping may fail.
runtime.wrap_udp_socket(socket.into())?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the QUIC endpoint creation process to utilize an abstract socket, enhancing runtime management and error handling.