Make LOGFILE readonly after assignment #6261
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR aim to accomplish?:
Fixes
pihole -t
erroring out with/usr/local/bin/pihole: line 393: LOGFILE: readonly variable
Shellcheck does insist that variable declaration and variable assignment happen on two different lines but
readonly
variables need to be assigned first and then set asreadonly
https://www.shellcheck.net/wiki/SC2155
How does this PR accomplish the above?:
Flip declaration and
readonly
assignment.By submitting this pull request, I confirm the following:
git rebase
)