Skip to content

Conversation

dschaper
Copy link
Member

What does this PR aim to accomplish?:

Fixes pihole -t erroring out with /usr/local/bin/pihole: line 393: LOGFILE: readonly variable

Shellcheck does insist that variable declaration and variable assignment happen on two different lines but readonly variables need to be assigned first and then set as readonly

https://www.shellcheck.net/wiki/SC2155

Problematic code in the case of readonly:

readonly foo="$(mycmd)"

Correct code:

foo="$(mycmd)"
readonly foo

How does this PR accomplish the above?:

Flip declaration and readonly assignment.


By submitting this pull request, I confirm the following:

  1. I have read and understood the contributors guide, as well as this entire template. I understand which branch to base my commits and Pull Requests against.
  2. I have commented my proposed changes within the code and I have tested my changes.
  3. I am willing to help maintain this change if there are issues with it later.
  4. It is compatible with the EUPL 1.2 license
  5. I have squashed any insignificant commits. (git rebase)
  6. I have checked that another pull request for this purpose does not exist.
  7. I have considered, and confirmed that this submission will be valuable to others.
  8. I accept that this submission may not be used, and the pull request closed at the will of the maintainer.
  9. I give this submission freely, and claim no ownership to its content.

  • I have read the above and my PR is ready for review. Check this box to confirm

Signed-off-by: Dan Schaper <dan.schaper@pi-hole.net>
@dschaper dschaper requested a review from a team as a code owner May 31, 2025 15:30
@yubiuser yubiuser merged commit 03b3b69 into development Jun 1, 2025
15 checks passed
@yubiuser yubiuser deleted the fix/tailFunc-readOnly branch June 1, 2025 13:47
@pralor-bot
Copy link

This pull request has been mentioned on Pi-hole Userspace. There might be relevant details there:

https://discourse.pi-hole.net/t/unable-to-tail-logfile-after-latest-update/80290/2

@pralor-bot
Copy link

This pull request has been mentioned on Pi-hole Userspace. There might be relevant details there:

https://discourse.pi-hole.net/t/sudo-pihole-t/80288/2

@dschaper dschaper mentioned this pull request Jun 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants