Skip to content

Conversation

yubiuser
Copy link
Member

@yubiuser yubiuser commented May 4, 2025

What does this PR aim to accomplish?:

During fresh installation, we ask the user which interface should be used for Pi-hole. This populates PIHOLE_INTERFACE, but we never used the var for anything. This PR now sets the this as dns.interface which can be used by FTL if necessary.
Reported on discourse: https://discourse.pi-hole.net/t/problems-setting-up-new-v6-installation/79633

P.S. By default, the listening mode is local which means dns.interface is unused. But the web interface allows with a single click to switch to a different listening mode which will use the specified interface.


By submitting this pull request, I confirm the following:

  1. I have read and understood the contributors guide, as well as this entire template. I understand which branch to base my commits and Pull Requests against.
  2. I have commented my proposed changes within the code and I have tested my changes.
  3. I am willing to help maintain this change if there are issues with it later.
  4. It is compatible with the EUPL 1.2 license
  5. I have squashed any insignificant commits. (git rebase)
  6. I have checked that another pull request for this purpose does not exist.
  7. I have considered, and confirmed that this submission will be valuable to others.
  8. I accept that this submission may not be used, and the pull request closed at the will of the maintainer.
  9. I give this submission freely, and claim no ownership to its content.

  • I have read the above and my PR is ready for review. Check this box to confirm

Signed-off-by: Christian König <github@yubiuser.dev>
@yubiuser yubiuser requested a review from a team May 4, 2025 17:46
@pralor-bot
Copy link

This pull request has been mentioned on Pi-hole Userspace. There might be relevant details there:

https://discourse.pi-hole.net/t/problems-setting-up-new-v6-installation/79633/11

@yubiuser yubiuser merged commit 7aaaa49 into development May 5, 2025
15 checks passed
@yubiuser yubiuser deleted the fix/dns.interface branch May 5, 2025 06:39
@PromoFaux PromoFaux mentioned this pull request May 6, 2025
@pralor-bot
Copy link

This pull request has been mentioned on Pi-hole Userspace. There might be relevant details there:

https://discourse.pi-hole.net/t/interfqces-not-shown-can-not-select-wg0/80185/2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants