Set dns.interface during installation #6216
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR aim to accomplish?:
During fresh installation, we ask the user which interface should be used for Pi-hole. This populates
PIHOLE_INTERFACE
, but we never used the var for anything. This PR now sets the this asdns.interface
which can be used by FTL if necessary.Reported on discourse: https://discourse.pi-hole.net/t/problems-setting-up-new-v6-installation/79633
P.S. By default, the listening mode is
local
which meansdns.interface
is unused. But the web interface allows with a single click to switch to a different listening mode which will use the specified interface.By submitting this pull request, I confirm the following:
git rebase
)