-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
fix: docker base version detection for dependabot #1832
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: docker base version detection for dependabot #1832
Conversation
4de9029
to
9b0e9ec
Compare
Thanks! The only issue I have with this currently is that we set the alpine version in GHA (granted, this is also out of date) docker-pi-hole/.github/workflows/build-and-publish.yml Lines 24 to 27 in 152dd7a
Which now leaves me wondering what is best to do for the RISCV arch, which needs to be built on |
Do we need some dependabot policy? Because the |
ad0887e
to
bbd19a4
Compare
@PromoFaux @yubiuser |
Signed-off-by: LizenzFass78851 <82592556+LizenzFass78851@users.noreply.github.com>
1fc5afa
to
928a791
Compare
Signed-off-by: LizenzFass78851 <82592556+LizenzFass78851@users.noreply.github.com>
Signed-off-by: LizenzFass78851 <82592556+LizenzFass78851@users.noreply.github.com>
Signed-off-by: LizenzFass78851 <82592556+LizenzFass78851@users.noreply.github.com>
928a791
to
4016b9f
Compare
Did work! |
Description
At the same time, it adds the ability to search for updates of the base image for the docker image located in the test directoryMotivation and Context
Because otherwise the Docker base updates would be forget. For example, Alpine version 3.22 was released recently. According to the GitHub runner's log, dependabot always runs on Sundays, but it didn't recognize the base image tags and therefore can't searched for updates, for example, Alpine releases.
How Has This Been Tested?
I tested these changes in my fork and manually triggered dependabot and it recognized the updates for the base images after the change.

(I just can't test it more precisely because certain github actions on my account aren't working properly at the moment)Types of changes
Checklist: