Skip to content

Conversation

LizenzFass78851
Copy link
Contributor

@LizenzFass78851 LizenzFass78851 commented Jun 6, 2025

Description

  • This changes the from lines of the two dockerfiles (src and test) so that depentabot can automatically detect updates to the base images again.
  • At the same time, it adds the ability to search for updates of the base image for the docker image located in the test directory

Motivation and Context

Because otherwise the Docker base updates would be forget. For example, Alpine version 3.22 was released recently. According to the GitHub runner's log, dependabot always runs on Sundays, but it didn't recognize the base image tags and therefore can't searched for updates, for example, Alpine releases.

How Has This Been Tested?

I tested these changes in my fork and manually triggered dependabot and it recognized the updates for the base images after the change. (I just can't test it more precisely because certain github actions on my account aren't working properly at the moment)
Screenshot 2025-06-06 at 13-30-25 Pull requests · LizenzFass78851_docker-pi-hole

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@LizenzFass78851 LizenzFass78851 force-pushed the fix/docker-base-update branch from 4de9029 to 9b0e9ec Compare June 6, 2025 11:17
@PromoFaux
Copy link
Member

Thanks!

The only issue I have with this currently is that we set the alpine version in GHA (granted, this is also out of date)

alpine_version: [3.19]
include:
- platform: linux/riscv64
alpine_version: edge

Which now leaves me wondering what is best to do for the RISCV arch, which needs to be built on edge (I think... something may have changed here since added RISC support)

@yubiuser
Copy link
Member

yubiuser commented Jun 6, 2025

Do we need some dependabot policy? Because the cli image changes quite often.

@LizenzFass78851 LizenzFass78851 force-pushed the fix/docker-base-update branch 2 times, most recently from ad0887e to bbd19a4 Compare June 6, 2025 12:11
@LizenzFass78851
Copy link
Contributor Author

@PromoFaux
I have changed something in the form lines which means that you can assign separate tags for each architecture (e.g. for riscv alpine edge and for the rest alpine stable version). This would also allow dependabot to continue to find alpine updates for the dockerfile.

@yubiuser
I removed the commit that included the test directory in the dependabot config.

Signed-off-by: LizenzFass78851 <82592556+LizenzFass78851@users.noreply.github.com>
@LizenzFass78851 LizenzFass78851 force-pushed the fix/docker-base-update branch 2 times, most recently from 1fc5afa to 928a791 Compare June 6, 2025 13:39
Signed-off-by: LizenzFass78851 <82592556+LizenzFass78851@users.noreply.github.com>
Signed-off-by: LizenzFass78851 <82592556+LizenzFass78851@users.noreply.github.com>
Signed-off-by: LizenzFass78851 <82592556+LizenzFass78851@users.noreply.github.com>
@LizenzFass78851 LizenzFass78851 force-pushed the fix/docker-base-update branch from 928a791 to 4016b9f Compare June 6, 2025 13:42
@PromoFaux PromoFaux requested a review from yubiuser June 6, 2025 15:14
@yubiuser yubiuser merged commit aa1cc8b into pi-hole:development Jun 6, 2025
4 checks passed
@LizenzFass78851 LizenzFass78851 deleted the fix/docker-base-update branch June 6, 2025 16:24
@yubiuser
Copy link
Member

yubiuser commented Jun 6, 2025

Did work!

#1833

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants