Skip to content

Prevent container from starting on old versions of docker due to incompatibility with newer versions of alpine #1794

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 24, 2025
Merged

Prevent container from starting on old versions of docker due to incompatibility with newer versions of alpine #1794

merged 1 commit into from
Mar 24, 2025

Conversation

LizenzFass78851
Copy link
Contributor

Description

This adds a test when running the Docker image that checks if the if [... logic works. If not, the user will see a message in the docker logs that their Docker is too old and will be prompted to update.
Furthermore, the container is terminated with exit 1.

Motivation and Context

This (hopefully) fixes: #1767

How Has This Been Tested?

I tested this on an Ubuntu 20.04 VM with an outdated containerd.io package to be able to reproduce the bash alpine issue and test its fix. More details here or here

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@LizenzFass78851
Add a test to check if running a old version of docker
0d241ef 
Signed-off-by: LizenzFass78851 <82592556+LizenzFass78851@users.noreply.github.com>
@mwoolweaver
Copy link
Contributor

mwoolweaver commented Mar 24, 2025 •
edited
Loading

Should this be added back to the readme?

#1767 (comment)

Due to moby/moby#40734, you may run into issues running 2022.04 and later on host systems with an older version of libseccomp2 (Such as Debian/Raspbian buster or Ubuntu 20.04, and maybe CentOS 7).

The first recommendation is to upgrade your host OS, which will include a more up to date (and fixed) version of libseccomp.

If you absolutely cannot do this, some users #1042 (comment) success in updating libseccomp2 via backports on debian, or similar via updates on Ubuntu. You can try this workaround at your own risk (Note, you may also find that you need the latest docker.io (more details here)

@LizenzFass78851
Copy link
Contributor Author

Should this be added back to the readme?

If @PromoFaux is in favor then please also as a separate pull request

@yubiuser yubiuser requested a review from PromoFaux March 24, 2025 19:36
@mwoolweaver
Copy link
Contributor

mwoolweaver commented Mar 24, 2025 •
edited
Loading

Honestly I feel like it being mentioned in this PR and other issues is enough of a bread crumb for most.

@PromoFaux
Copy link
Member

Built, published to my personal repository and then tested using the dockerfile you shared in the linked issue: https://asciinema.org/a/ajEuWlTbJANYVSBi3nSZ7MzVr

Approving but will change the title

@PromoFaux PromoFaux changed the title fix: alpine issue pt. 2 Prevent container from starting on old versions of docker due to incompatibility with newer versions of alpine Mar 24, 2025
@PromoFaux PromoFaux merged commit 5799c23 into pi-hole:development Mar 24, 2025
5 checks passed
@PromoFaux
Copy link
Member

Honestly I feel like it being mentioned in this PR and other issues is enough of a bread crumb for most.

I also don't think it's that widespread an issue

@mwoolweaver
Copy link
Contributor

mwoolweaver commented Mar 24, 2025 •
edited
Loading

pi-hole/pi-hole#6030 should be reverted as well since it was the merged fix for this issue originally.

#1767 (comment)

@mwoolweaver mwoolweaver mentioned this pull request Mar 24, 2025
Merged
1 task
@LizenzFass78851 LizenzFass78851 deleted the fix/alpine-issue-2 branch March 25, 2025 05:07
This was referenced Apr 25, 2025
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PromoFaux PromoFaux PromoFaux approved these changes

@yubiuser yubiuser yubiuser approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@LizenzFass78851 @mwoolweaver @PromoFaux @yubiuser