Skip to content

Update alpine to 3.19 #1497

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Dec 22, 2023
Merged

Update alpine to 3.19 #1497

merged 4 commits into from
Dec 22, 2023

Conversation

yubiuser
Copy link
Member

@yubiuser yubiuser commented Dec 8, 2023

Updates the base alpine image to 3.19.

There is no v3.19 for docker-cli yet. I kept the v3.18 base there. This PR can be extended later when such an image comes available - or it could be handled in an other PR

@yubiuser yubiuser added the v6 label Dec 8, 2023
@yubiuser yubiuser requested a review from a team December 8, 2023 19:26
@yubiuser
Update alpine to 3.19
dbf3ddf 
Signed-off-by: Christian König <ckoenig@posteo.de>
@yubiuser
Update docker-cli also to v3.19
775c3a8 
Signed-off-by: Christian König <ckoenig@posteo.de>
@yubiuser
Copy link
Member Author

alpine 3.19 is now also available for docker-cli. I updated the workflow. PR is ready for review.

@yubiuser
Remove pipenv and allow pip to install systemwide with --break-system…
59cfc75 
…-packages

Signed-off-by: Christian König <ckoenig@posteo.de>
@yubiuser
Copy link
Member Author

Latest commit removed pipenv and allowed pip to "break" the system python packages. Python is enforcing the use of venv but setting this up increases the code complexity within our docker-on-docker test suite and makes it even harder to understand. As the container are disposable and only used to run the test, I see no issue with allowing pip to --break-system-packages.

@yubiuser
Re-add importand comment line
5f8ca18 
Signed-off-by: Christian König <ckoenig@posteo.de>
@yubiuser yubiuser requested a review from PromoFaux December 17, 2023 12:42
@yubiuser yubiuser merged commit a04a8ab into development-v6 Dec 22, 2023
@yubiuser yubiuser deleted the alpine3_19 branch December 22, 2023 14:08
@yubiuser yubiuser mentioned this pull request Dec 22, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DL6ER DL6ER DL6ER approved these changes

@PromoFaux PromoFaux Awaiting requested review from PromoFaux

Assignees
No one assigned
Labels
v6
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yubiuser @DL6ER