Skip to content

Conversation

DL6ER
Copy link
Member

@DL6ER DL6ER commented Mar 11, 2025

What does this implement/fix?

Do not store queries when database.maxDBdays is == 0, however, we still want to store the remaining meta-tables for the network table to work

Related issue or feature (if applicable): N/A

Pull request in docs with documentation (if applicable): N/A


By submitting this pull request, I confirm the following:

  1. I have read and understood the contributors guide, as well as this entire template. I understand which branch to base my commits and Pull Requests against.
  2. I have commented my proposed changes within the code.
  3. I am willing to help maintain this change if there are issues with it later.
  4. It is compatible with the EUPL 1.2 license
  5. I have squashed any insignificant commits. (git rebase)

Checklist:

  • The code change is tested and works locally.
  • I based my code and PRs against the repositories developmental branch.
  • I signed off all commits. Pi-hole enforces the DCO for all contributions
  • I signed all my commits. Pi-hole requires signatures to verify authorship
  • I have read the above and my PR is ready for review.

…ll want to store the remaining meta-tables for the network table to work

Signed-off-by: DL6ER <dl6er@dl6er.de>
Copy link
Member

@rdwebdesign rdwebdesign left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Correct operation confirmed by the user.

@DL6ER DL6ER merged commit 27bea5b into development Mar 12, 2025
18 checks passed
@DL6ER DL6ER deleted the fix/maxDBdays_networktbl branch March 12, 2025 04:09
@PromoFaux PromoFaux mentioned this pull request Mar 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants