Add menu with preferences/about buttons in headerbar #391
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BrainBlasted
reviewed
Jan 2, 2019
BrainBlasted
reviewed
Jan 2, 2019
BrainBlasted
reviewed
Jan 2, 2019
Co-Authored-By: yannicka <yannicka@users.noreply.github.com>
Co-Authored-By: yannicka <yannicka@users.noreply.github.com>
BrainBlasted
reviewed
Jan 3, 2019
BrainBlasted
reviewed
Jan 3, 2019
|
You'll want to remove |
- Add new window entry - Update formatting - Make use of Gtk 3.20
|
@yannicka @BrainBlasted Thanks a lot to both of you for this and sorry for the long delay. This project basically lay dormant for too long now, I really want to get back to updating it. @BrainBlasted Thanks also for the detailed review, I think I have addressed all issues you found. I'm going ahead and merge this, if you have anything to add please let me know. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #379
(please test carefully, I am not a GTK/GNOME/Vala developer)