Skip to content

Add permissions for creating issues to trusted root cert check job #237

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 6, 2025

Conversation

asgrim
Copy link
Collaborator

@asgrim asgrim commented May 6, 2025

Fix for #235 (comment)

@asgrim asgrim added this to the 0.11.0 milestone May 6, 2025
@asgrim asgrim self-assigned this May 6, 2025
@asgrim asgrim added the bug Something isn't working label May 6, 2025
@asgrim asgrim force-pushed the permissions-for-issues branch from 5ba98d5 to 31e23d8 Compare May 6, 2025 21:26
@asgrim asgrim requested a review from TimWolla May 6, 2025 21:33
@asgrim asgrim merged commit 5f2b077 into php:main May 6, 2025
19 checks passed
@asgrim asgrim deleted the permissions-for-issues branch May 6, 2025 21:42
Copy link
Member

@TimWolla TimWolla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Already merged, but since you requested a review, LGTM.

@asgrim
Copy link
Collaborator Author

asgrim commented May 7, 2025

Already merged, but since you requested a review, LGTM.

Thanks :) wanted to get it merged before scheduled job just to make sure it was all happy (it was!) :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants