Skip to content

Add self-update functionality #205

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 15 commits into from
Apr 2, 2025
Merged

Add self-update functionality #205

merged 15 commits into from
Apr 2, 2025

Conversation

asgrim
Copy link
Collaborator

@asgrim asgrim commented Mar 24, 2025

Fixes #66

@asgrim asgrim added the enhancement New feature or request label Mar 24, 2025
@asgrim asgrim added this to the 0.9.0 milestone Mar 24, 2025
@asgrim asgrim self-assigned this Mar 24, 2025
@asgrim asgrim marked this pull request as draft March 24, 2025 10:24
@asgrim asgrim force-pushed the pie-self-update branch from 8672475 to dd8fdbd Compare April 1, 2025 11:52
TimWolla
TimWolla reviewed Apr 1, 2025
View reviewed changes
@asgrim asgrim force-pushed the pie-self-update branch 2 times, most recently from e4f7a41 to 42a4665 Compare April 1, 2025 19:32
asgrim and others added 14 commits April 1, 2025 21:00
@asgrim
Initial structure of self-update command with skeleton of verification
2b91430
@asgrim @TimWolla
Added fallback approach for verifying downloaded PIE phar provenance
ac3e795 
Co-authored-by: Tim Düsterhus <tim@tideways-gmbh.com>
@asgrim
Ensure we are running in PHAR mode before attempting self-update
9bf1174
@asgrim
Write new pie.phar to script location
a9487e9
@asgrim
Improve attestation shape verification
002c58d
@asgrim
Extract Attestation parsing into simpler VO
19fc37e
@asgrim
Split verification into method-specific classes
c3b3f83
@asgrim
Introduce VerifyPieReleaseUsingAttestation factory
19095eb
@asgrim
Added GH CLI verification using gh
4cb4923
@asgrim
Handle logic for nightly releases if requested
5876718
@asgrim
Unit tests for the new verify/update methods
bdf6e42
@asgrim
Use BAT files for Windows tests for exit differences
08f5ef5
@asgrim
Verify facts about the attestation certificate and its authenticity u…
37807de 
…sing a trusted root store
@asgrim @TimWolla
Improvements for readability and correctness from PR review
5ddde91 
Co-authored-by: Tim Düsterhus <tim@tideways-gmbh.com>
@asgrim asgrim force-pushed the pie-self-update branch from 42a4665 to 5ddde91 Compare April 1, 2025 20:02
@asgrim asgrim marked this pull request as ready for review April 1, 2025 20:02
@asgrim asgrim requested a review from TimWolla April 1, 2025 20:18
@asgrim asgrim mentioned this pull request Apr 1, 2025
Closed
TimWolla
TimWolla reviewed Apr 2, 2025
View reviewed changes
Copy link
Member

@TimWolla TimWolla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, except for the two small remarks.

TimWolla
TimWolla reviewed Apr 2, 2025
View reviewed changes
@asgrim @TimWolla
Split out and improve attestation verification from PR discussion
69e34e1 
Co-authored-by: Tim Düsterhus <tim@tideways-gmbh.com>
@asgrim asgrim merged commit bd03d4a into php:main Apr 2, 2025
19 checks passed
@asgrim asgrim deleted the pie-self-update branch April 2, 2025 19:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TimWolla TimWolla TimWolla approved these changes

Assignees

@asgrim asgrim

Labels
enhancement New feature or request
Projects
None yet
Milestone
0.9.0
Development

Successfully merging this pull request may close these issues.

PIE self-update command
2 participants
@asgrim @TimWolla