bugfix: Episode empty AirDate returns wrong DateTime #243
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## 4.0 #243 +/- ##
============================================
- Coverage 84.45% 84.43% -0.02%
- Complexity 2166 2167 +1
============================================
Files 196 196
Lines 5454 5456 +2
============================================
+ Hits 4606 4607 +1
- Misses 848 849 +1
Continue to review full report at Codecov.
|
wtfzdotnet
reviewed
Sep 25, 2021
lib/Tmdb/Model/Tv/Episode.php
Outdated
Comment on lines
167
to
169
| if ($airDate === '') { | ||
| $airDate = null; | ||
| } elseif (!$airDate instanceof DateTime && $airDate !== null) { |
There was a problem hiding this comment.
@ptheofan think we are better off changing the check to not empty ( and we could definitively still be more defensive ), would you mind checking if this might occur in different models?
Suggested change
| if ($airDate === '') { | |
| $airDate = null; | |
| } elseif (!$airDate instanceof DateTime && $airDate !== null) { | |
| } elseif (!$airDate instanceof DateTime && !empty($airDate)) { |
There was a problem hiding this comment.
Couldn't agree more. Didn't go with empty in the first place as a lot of people find it to be tricky for junior devs. :)
Similar PR for the movie model #244
simplified check using empty and reduced complexity of instanceof Datetime
wtfzdotnet
approved these changes
Dec 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Patch for Issue #242