Skip to content

Wrong birthday is set if a Person doesn't have a full birth date. #180

@koichirose

Description

@koichirose

Consider this person, https://www.themoviedb.org/person/12677-matthew-robbins

This is the response for person/12677:

{
  "birthday": "1945",
  "deathday": null,
  "id": 12677,
  "name": "Matthew Robbins",
  "also_known_as": [],
  "gender": 2,
  "biography": "​From Wikipedia, the free encyclopedia.  \n\nMatthew Robbins (born circa 1945) is an American screenwriter, film producer and director. He is good friends with Steven Spielberg, George Lucas, Guillermo Del Toro and Walter Murch and has had cameo appearances in THX 1138 and Close Encounters of the Third Kind. Robbins frequently worked with Hal Barwood. He recently wrote the screenplay for the Bollywood thriller 7 Khoon Maaf, along with Vishal Bhardwaj.\n\nDescription above from the Wikipedia article Matthew Robbins  licensed under CC-BY-SA, full list of contributors on Wikipedia.",
  "popularity": 0.649037,
  "place_of_birth": null,
  "profile_path": "/oK61i61u3G5zZO5EtXmepY9IxGy.jpg",
  "adult": false,
  "imdb_id": "nm0730422",
  "homepage": null
}

This is the birthday set by php-tmdb:

object(DateTime)#1137 (3) {
  ["date"]=>
  string(26) "2018-05-04 19:45:00.000000"
  ["timezone_type"]=>
  int(3)
  ["timezone"]=>
  string(11) "Europe/Rome"
}

where 2018-05-04 is today's date and the birth year is parsed as the hours:minutes.
I guess this is happening here: https://github.com/php-tmdb/api/blob/2.1/lib/Tmdb/Model/Person.php#L226

The same may be happening for death date and possibly other dates.
I suggest setting the date to NULL or adding some other property that warns the developer that the date is not a full date (YYYY-MM-DD).

Unfortunately I'm not able to do this myself at this time.

Metadata

Metadata

Assignees

Type

No type

Projects

No projects

Relationships

None yet

Development

No branches or pull requests

Issue actions