Skip to content

Import from io.Reader #72

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
May 5, 2024
Merged

Import from io.Reader #72

merged 4 commits into from
May 5, 2024

Conversation

philippgille
Copy link
Owner

@philippgille philippgille commented May 4, 2024 •
edited
Loading

This PR adds DB.ImportFromReader, and implements the internal readFromReader.

The export/writer counterpart is #71.

Both PRs combined address issue #70.

Example code follows in #73.

@philippgille philippgille mentioned this pull request May 4, 2024
Merged
@philippgille philippgille force-pushed the import-from-reader branch from 3070a90 to ff98d0a Compare May 4, 2024 20:18
@philippgille philippgille mentioned this pull request May 4, 2024
Merged
@philippgille philippgille marked this pull request as ready for review May 4, 2024 20:22
@philippgille philippgille mentioned this pull request May 4, 2024
Closed
@philippgille philippgille merged commit 041e3c0 into main May 5, 2024
@philippgille philippgille deleted the import-from-reader branch May 5, 2024 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@erikdubbelboer erikdubbelboer erikdubbelboer approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@philippgille @erikdubbelboer