Skip to content

Conversation

villfa
Copy link
Contributor

@villfa villfa commented Dec 29, 2021

This PR is not meant to be a definitive solution but it will mitigate #274.

@theseer
Copy link
Member

theseer commented Dec 29, 2021

This looks redundant to something I already did somewhere... Let me check if that's correct..

@theseer
Copy link
Member

theseer commented Dec 29, 2021

Ah, I of course only did that in the explicit Github Resolver, not when the phar.io alias is used. Nice catch. And yet again a sign that the current design for resolving and downloading related data is not optimal.

Thanks for this.

@theseer theseer merged commit 28020bd into phar-io:master Dec 29, 2021
@villfa villfa deleted the fix/274 branch December 29, 2021 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants