fix: ArrayIndexOutOfBounds when write big object into GSS enabled connection, make GSSInputStream robust in face of streams that produce incomplete reads #3500
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9 tasks
63e89c4 to
ccc3936
Compare
…nection, make GSSInputStream robust in face of streams that produce incomplete reads fix this error stack ``` java.lang.ArrayIndexOutOfBoundsException: null at java.security.jgss/sun.security.jgss.GSSContextImpl.unwrap at sun.security.jgss.GSSContextImpl.wrap(GSSContextImpl.java:385) at org.postgresql.gss.GSSOutputStream.writeWrapped(GSSOutputStream.java:52) at org.postgresql.gss.GSSOutputStream.write(GSSOutputStream.java:76) at java.io.FilterOutputStream.write(FilterOutputStream.java:97) at org.postgresql.core.PGStream.send(PGStream.java:398) ``` GSSOutputStream does not handle the buffer switch correctly, when a message is bigger than the GSS buffer due to a wrong buffer variable usage. GSSInputStream did not handle input streams that produced incomplete reads as it ignored the result of .read(...) Co-authored-by: Sasasu <i@sasa.su>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a re-implementation of #3492
GSSOutputStream does not handle the buffer switch correctly, when a message is bigger than the GSS buffer due to a wrong buffer variable usage.
GSSInputStream did not handle input streams that produced incomplete reads as it ignored the result of .read(...)