Skip to content

Issue 2087 pgr_extractVertices #2182

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 12, 2021
Merged

Issue 2087 pgr_extractVertices #2182

merged 2 commits into from
Oct 12, 2021

Conversation

cvvergara
Copy link
Member

Fixes #2087

Changes proposed in this pull request:

  • Changes the classification of pgr_extractVertices
    • Availability
    • NEWS
    • Release notes
    • removed from experimental section
    • added into proposed section
    • Comment on function updated

Additionally,
I found out very confusing the test names, when choosing which tests must pass before it is merged, as seen here:
image

  • Build to more meaningful name

Thanks @TimMcCauley for taking your time to test the function and review it

@pgRouting/admins

@cvvergara cvvergara added this to the Release 3.3.0 milestone Oct 11, 2021
@cvvergara cvvergara changed the title Issue 2087 Issue 2087 pgr_extractVertices Oct 11, 2021
@cvvergara cvvergara merged commit 6b3dd84 into pgRouting:develop Oct 12, 2021
@cvvergara cvvergara deleted the issue-2087 branch October 12, 2021 00:20
@cvvergara cvvergara mentioned this pull request Mar 1, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dkastl dkastl dkastl approved these changes

@cayetanobv cayetanobv Awaiting requested review from cayetanobv

@omshinde omshinde Awaiting requested review from omshinde

@krashish8 krashish8 Awaiting requested review from krashish8

Assignees
No one assigned
Labels
Functionality/proposed Topology
Projects
None yet
Milestone
Release 3.3.0
Development

Successfully merging this pull request may close these issues.
2 participants
@cvvergara @dkastl