Skip to content

Conversation

adrien-berchet
Copy link
Contributor

Fixes #1336 , #1074 , #1009 .

Changes proposed in this pull request:

  • Fix pgr_nodeNetwork() function
  • Add tests

@pgRouting/admins

@cvvergara
Copy link
Member

cvvergara commented Jan 14, 2020

@adrien-berchet

From reading the code things look much much better, I will check & test with more detail later on the week.

On the mean time you can work on this:

  • Looks like in pgtap/topology/nodeNetwork.test.sql you added has the steps to reproduce the problem mentioned on pgr_nodeNetwork issues #1336 and tested them. I prefer that you create a test file named issue-1336.sql where to put those new tests and remove those new tests from pgtap/topology/nodeNetwork.test.sql
  • Please also make a commit where you add your name here
    and here

If possible this:

  • you can add a tests files issue-1074.sql and issue-1009.sql that make a simple test over those issues that you are fixing. (trying to the best of your ability to use the issue openers/comments information)

The way I will test this is:

  1. I will use your test files with current code and I am expecting to get pgtap fails
  2. Then I will use your test files with the changes you made I am expecting to get pgtap successes

With (1) I see that is an appropriate test to catch the problem
With (2) I see that the problem is fixed

@cvvergara cvvergara self-requested a review January 14, 2020 22:48
@adrien-berchet
Copy link
Contributor Author

@cvvergara
It should be ok now, I let you check.

@cvvergara cvvergara changed the title Fix pgr_nodeNetwork Fix pgr_nodeNetwork close #1336 #1074 #1009 Jan 20, 2020
@cvvergara cvvergara self-requested a review January 20, 2020 19:35
@cvvergara cvvergara merged commit 77747d8 into pgRouting:master Jan 20, 2020
@cvvergara cvvergara added this to the Release 3.0.0 milestone Jan 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pgr_nodeNetwork issues
2 participants