GSoC 2023: Aryan Gupta week 3 #305
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krashish8
reviewed
Jun 18, 2023
There was a problem hiding this comment.
The changes look good. Please push new changes (if any) and merge this PR and send the weekly report.
(What we generally expect is - at the beginning of the week, create a PR and at the end, merge it without waiting for review). We will add the comments eventually if we feel that something needs improvement, otherwise, it is fine.
| @@ -9,6 +9,7 @@ | |||
| doc-pgr_drivingDistance | |||
| )], | |||
| 'documentation' => [qw( | |||
| dijksraDD-issue729 | |||
There was a problem hiding this comment.
I think this should be removed, because we are not using the query on the documentation (docs.pgrouting.org, aka in the rst files)
There was a problem hiding this comment.
i removed it further commits already 👍
Co-authored-by: Ashish Kumar <ashishkr23438@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes # .
Changes proposed in this pull request:
@pgRouting/admins