manually unravel to avoid 32bit overflows #11
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switched back to
divmodto unravel with the new shape.That's not needed for ndim == 1 case because 32-bit overflow in 1d case is valid.
So,
unravel_indexworks for ndim==1 with a one-liner if we avoid calling_ravel_indicesso I did that.Change back if you prefer.
Based on that, inside
_ravel_indicesI switched the order of checking len(indices) because only resize will call it with ndim==1.Hopefully this will satisfy the 32-bit overflows. fingers crossed...