Skip to content

Fix: Add iconv extension for twig 3.x #538

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 30, 2025
Merged

Fix: Add iconv extension for twig 3.x #538

merged 1 commit into from
Mar 30, 2025

Conversation

PierrePaul
Copy link
Contributor

@PierrePaul PierrePaul commented Mar 29, 2025 •
edited
Loading

Target branch is perftools:dependabot/composer/twig/twig-3.11.2 to fix an issue on PR #510 .

Without the iconv extension, we get the error :

Type: Twig\Error\RuntimeError
Message: An exception has been thrown during the rendering of a template ("Call to undefined function Symfony\Polyfill\Mbstring\iconv_strlen()").
File: /var/www/xhgui/templates/runs/paginated-list.twig

This PR adds the php8-iconv extension.

@PierrePaul PierrePaul mentioned this pull request Mar 29, 2025
Merged
@dependabot dependabot bot force-pushed the dependabot/composer/twig/twig-3.11.2 branch from 21abd5c to 03daefa Compare March 29, 2025 10:38
@glensc
Copy link
Contributor

glensc commented Mar 29, 2025

what is the error? please update PR body with detail.

@glensc
Copy link
Contributor

glensc commented Mar 29, 2025

seems you set the target branch to dependabot/composer/twig/twig-3.11.2, which is #510. you should had mentioned this in pr body.

@dependabot dependabot bot force-pushed the dependabot/composer/twig/twig-3.11.2 branch 3 times, most recently from 48f4c21 to acbcbd5 Compare March 29, 2025 12:02
@PierrePaul PierrePaul force-pushed the dependabot/composer/twig/twig-3.11.2 branch from d2b588f to dcdd0de Compare March 29, 2025 14:13
@glensc glensc changed the title Adding iconv extension. Twig upgrade to 3.11 calls iconv_strlen. Fix: Add iconv extension for twig 3.x Mar 30, 2025
@glensc glensc merged commit 9a7892d into perftools:dependabot/composer/twig/twig-3.11.2 Mar 30, 2025
5 checks passed
@glensc
Copy link
Contributor

glensc commented Mar 30, 2025

FYI: I strive for imperative style in commit messages (and pr titles):

@glensc glensc added this to the 0.23.2 milestone Mar 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.23.2
Development

Successfully merging this pull request may close these issues.
2 participants
@PierrePaul @glensc