Skip to content

Update php version to 8.0 #509

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 28, 2025
Merged

Update php version to 8.0 #509

merged 2 commits into from
Mar 28, 2025

Conversation

PierrePaul
Copy link
Contributor

@PierrePaul PierrePaul commented Mar 27, 2025 •
edited
Loading

This PR updates php to version 8.0.
See #508 for the reasoning behind this change.

@glensc glensc changed the title refs #508: update php version to 8.0, for now. Update php version to 8.0 Mar 28, 2025
@glensc
Copy link
Contributor

glensc commented Mar 28, 2025

Confirmed Alpine 3.15 installs php 8.0

❯ docker --context sandra run --rm -it alpine:3.15  sh
/ # apk add php8-cli
fetch https://dl-cdn.alpinelinux.org/alpine/v3.15/main/x86_64/APKINDEX.tar.gz
fetch https://dl-cdn.alpinelinux.org/alpine/v3.15/community/x86_64/APKINDEX.tar.gz
(1/9) Installing php8-common (8.0.25-r0)
(2/9) Installing argon2-libs (20190702-r1)
(3/9) Installing ncurses-terminfo-base (6.3_p20211120-r2)
(4/9) Installing ncurses-libs (6.3_p20211120-r2)
(5/9) Installing libedit (20210910.3.1-r0)
(6/9) Installing pcre2 (10.42-r0)
(7/9) Installing xz-libs (5.2.5-r1)
(8/9) Installing libxml2 (2.9.14-r2)
(9/9) Installing php8 (8.0.25-r0)
Executing busybox-1.34.1-r7.trigger
OK: 17 MiB in 23 packages
/ #

@glensc
Copy link
Contributor

glensc commented Mar 28, 2025

The indentation is a bit mixed, will fix outside pull request.

also, you don't need to create issue to create a pull request.

@glensc glensc merged commit e9d30ad into perftools:0.23.x Mar 28, 2025
glensc added a commit that referenced this pull request Mar 28, 2025
@glensc
Use consistent indent. #509
6976b9a
@glensc glensc mentioned this pull request Mar 28, 2025
Closed
@glensc glensc added this to the 0.23.0 milestone Mar 28, 2025
@glensc
Copy link
Contributor

glensc commented Mar 29, 2025 •
edited
Loading

Why was "8.0" not added tests-mongo.yml?

Adding it:

@glensc glensc mentioned this pull request Mar 29, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.23.0
Development

Successfully merging this pull request may close these issues.
2 participants
@PierrePaul @glensc