Add missing simpleurl("") function. #1
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
An error was being thrown because the function simpleURL was not found so I added it.
preinheimer
added a commit
that referenced
this pull request
Jan 4, 2013
Add missing simpleurl("") function.
|
Thanks! Sorry this was needed, clearly we're still running around trying to finish stuff up |
|
No worries, happy to help. looking great so far. |
|
Perhaps the external/header.php file should also include the utitilty.php file. I think we're going to need get some better structure around how functions and classes are loaded/managed over time. |
|
Hrm. In my head there's two quite competing goals with that:
|
|
Avoiding code duplication is always the most important factor in maintenance. If we're careful about how many functions/classes are required to log profile data we can keep it lightweight and avoid duplication. |
glensc
added a commit
that referenced
this pull request
Mar 30, 2025
> 17x: parse_str(): Passing null to parameter #1 ($string) of type string is deprecated
glensc
added a commit
that referenced
this pull request
Mar 30, 2025
> 17x: parse_str(): Passing null to parameter #1 ($string) of type string is deprecated
glensc
added a commit
that referenced
this pull request
Mar 30, 2025
> 17x: parse_str(): Passing null to parameter #1 ($string) of type string is deprecated
glensc
added a commit
that referenced
this pull request
Mar 30, 2025
> 17x: parse_str(): Passing null to parameter #1 ($string) of type string is deprecated
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An error was being thrown because the function simpleURL was not found so I added it.