Add active peer notification #273
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* main: change app ID to com.bitchat.droid (permissionlesstech#270) bump to 0.9 (permissionlesstech#269) Sign announcements (permissionlesstech#267) fix fragmentation baby (permissionlesstech#266) Changes bitchat protocol (permissionlesstech#265)
|
@callebtc any chance you can review this one? 🙏 |
thank you for this! I thought we had this already, might have gone missing in combat? could you remove the conflicts before I review and merge? |
* main: (22 commits) Nip17 dms to extend the mesh (permissionlesstech#313) bump to 1.2.0 fix nip-17 (permissionlesstech#305) Geohash-specific relays (permissionlesstech#306) fix teleport tag and icons (permissionlesstech#303) UI changes and fixes (permissionlesstech#301) country -> region, region –> province (permissionlesstech#298) slightly increase padding (permissionlesstech#295) New about sheet (permissionlesstech#294) bump version (permissionlesstech#293) Statusbar seamless (permissionlesstech#289) Geohash notifications (permissionlesstech#288) Link preview (permissionlesstech#286) user bottom sheet (permissionlesstech#285) persist last channel (permissionlesstech#284) bump version code (permissionlesstech#283) UI fixes 2 (permissionlesstech#282) Scroll fix (permissionlesstech#281) fix minify errors (permissionlesstech#280) bump version (permissionlesstech#277) ...
@callebtc done! There are some strange formatting that my IDE is auto correcting that is caught up in this PR. Is that ok or do you prefer the previous formatting? |
|
@minhqto this is great, thank you. please contribute more! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Resolves #217
This PR adds an active peer push notification that informs users if there are fellow bitchatters nearby. This is similar to iOS's push notification for active peers.
The active peer push notification will be sent if:
For the future, we should add the capability to customize push notifications. As bitchat gets more popular, this push notification might become "spammy".
Checklist