Make Sidebar react to the nickname and RSSI changes. #228
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cool one! |
|
can you also help me figure out why the first click on the favorite icon doesn't reflect in the UI but I need to reopen the sidebar? maybe it's related. |
callebtc
approved these changes
Aug 5, 2025
4 tasks
Sure! Here's the PR with the fix - #237 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
If someone joins the network while the sidebar is open, their peer ID is displayed instead of their nickname until the Sidebar is reopened:
sidebar_before.mov
This change updates the Sidebar to react to the nickname and RSSI value changes so that the nickname is updated without having to reopen it:
sidebar_after.mov
Checklist